Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whatshap phase: Make --indels the default #346

Closed
marcelm opened this issue Dec 16, 2021 · 2 comments · Fixed by #469
Closed

whatshap phase: Make --indels the default #346

marcelm opened this issue Dec 16, 2021 · 2 comments · Fixed by #469

Comments

@marcelm
Copy link
Contributor

marcelm commented Dec 16, 2021

I suggest to enable indel phasing by default. The option doesn’t have the best name anyway (it also works with "complex" variants/MNPs). By instead adding an --only-snvs option, that naming issue would also be solved.

This may require bumping the version to 2.0.

@marcelm
Copy link
Contributor Author

marcelm commented Jun 29, 2023

Ping @tobiasmarschall @schrins Do you have an opinion on this? The option seems to work well enough and I think WhatsHap should aim to give the best possible phasing "out of the box", i.e., without providing any extra command-line arguments.

Raising this again because of #468, where @Npaffen was apparently not aware that --indels exists.

@schrins
Copy link
Collaborator

schrins commented Jun 29, 2023

I don't see any problems so far by including indels by default. Not knowing about this option indeed came up multiple times now.

marcelm added a commit that referenced this issue Jun 29, 2023
marcelm added a commit that referenced this issue Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants