New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What does adoptNode() return for DocumentFragment? #813

Open

TimothyGu opened this issue Dec 31, 2019 · 2 comments

Member

TimothyGu commented Dec 31, 2019

#754 adds to adoptNode():

If node is a DocumentFragment node whose host is non-null, then return.

But adoptNode() must return a Node. What does this "return" mean?

The text was updated successfully, but these errors were encountered:

Member

annevk commented Jan 2, 2020

Sigh, it seems that change introduced a bunch of errors. If we can fix the replaceChild() issue somehow I'd say it should return the node passed in, even though it was not adopted.

Perhaps I should first revert that change and test changes though while we figure out a new design. Thoughts welcome.

Member Author

TimothyGu commented Jan 2, 2020 •

edited

Loading

I think ~~that~~ reverting would be good, especially since none of the major browsers have implemented it. I'd be glad to use jsdom as a testbed for any such change.

TimothyGu added a commit to kontomondo/jsdom that referenced this issue


          Revert whatwg/dom#754

9e2dc90

See whatwg/dom#813

kontomondo mentioned this issue

update web-platform-tests to the latest jsdom/jsdom#2746

Merged

TimothyGu added a commit to kontomondo/jsdom that referenced this issue


          Update web-platform-tests to the latest

4896cec

Implementation of whatwg/dom#754 is delayed due to lingering issues with
the PR; see whatwg/dom#813.

Single-page to-upstream tests are updated to declare themselves as such;
per WPT RFC 28
(https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md).

Co-authored-by: Timothy Gu <timothygu99@gmail.com>

domenic pushed a commit to jsdom/jsdom that referenced this issue


          Update web-platform-tests to the latest

382bd82

Implementation of whatwg/dom#754 is delayed due to lingering issues with
the PR; see whatwg/dom#813.

Single-page to-upstream tests are updated to declare themselves as such;
per WPT RFC 28
(https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md).

Co-authored-by: Timothy Gu <timothygu99@gmail.com>

jdm mentioned this issue

Run adopt as part of insert servo/servo#25460

Closed

4 tasks

annevk added a commit that referenced this issue


          Revert "Run adopt as part of insert"

32cfc18

This reverts commit c825cea. See #813 and #814 for context.

annevk mentioned this issue

Adoption and DocumentFragment, part two #819

Open

annevk added a commit that referenced this issue


          Revert "Run adopt as part of insert"

6eb77d0

This reverts commit c825cea. See #813 and #814 for context.

annevk added a commit that referenced this issue


          Make adoption account for DocumentFragment nodes with hosts

8dafaf7

Tests: ...

Corresponding HTML PR: ...

Closes #813 and closes #814.

annevk added a commit that referenced this issue


          Revert "Run adopt as part of insert"

0e4ee38

This reverts commit c825cea. See #813 and #814 for context.

annevk added a commit that referenced this issue


          Make adoption account for DocumentFragment nodes with hosts

9a1e814

Tests: ...

Corresponding HTML PR: ...

Closes #813 and closes #814.

annevk mentioned this issue

What should adoptNode return for a DocumentFragment with a non-null host? #930

Closed

annevk added a commit that referenced this issue


          Revert "Run adopt as part of insert"

488eeab

This reverts commit c825cea. See #813 and #814 for context.

annevk added a commit that referenced this issue


          Make adoption account for DocumentFragment nodes with hosts

5c12594

Tests: ...

Corresponding HTML PR: ...

Closes #813 and closes #814.

annevk added a commit that referenced this issue


          Revert "Run adopt as part of insert"

2ebc0fa

This reverts commit c825cea. See #813 and #814 for context.

annevk added a commit that referenced this issue


          Make adoption account for DocumentFragment nodes with hosts

77ad4ca

Tests: ...

Corresponding HTML PR: ...

Closes #813 and closes #814.

annevk added a commit that referenced this issue


          Revert "Run adopt as part of insert"

1b137ba

This reverts commit c825cea. See #813 and #814 for context.

annevk added a commit that referenced this issue


          Make adoption account for DocumentFragment nodes with hosts

7afc950

Tests: web-platform-tests/wpt#22504.

Corresponding HTML PR: whatwg/html#5413.

Closes #813 and closes #814.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment