-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What does adoptNode() return for DocumentFragment? #813
Comments
Sigh, it seems that change introduced a bunch of errors. If we can fix the Perhaps I should first revert that change and test changes though while we figure out a new design. Thoughts welcome. |
I think |
Implementation of whatwg/dom#754 is delayed due to lingering issues with the PR; see whatwg/dom#813. Single-page to-upstream tests are updated to declare themselves as such; per WPT RFC 28 (https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md). Co-authored-by: Timothy Gu <timothygu99@gmail.com>
Implementation of whatwg/dom#754 is delayed due to lingering issues with the PR; see whatwg/dom#813. Single-page to-upstream tests are updated to declare themselves as such; per WPT RFC 28 (https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md). Co-authored-by: Timothy Gu <timothygu99@gmail.com>
Tests: web-platform-tests/wpt#22504. Corresponding HTML PR: whatwg/html#5413. Closes #813 and closes #814.
#754 adds to
adoptNode()
:But
adoptNode()
must return aNode
. What does this "return" mean?@annevk
The text was updated successfully, but these errors were encountered: