Define Event.srcElement and Event.returnValue #626

miketaylr · 2018-03-30T21:15:05Z

cvrebert · 2018-04-02T17:35:35Z

Fixes #625. (References in titles don't create cross-references in GitHub.)

cvrebert · 2018-04-02T17:38:03Z

dom.bs

@@ -446,6 +447,7 @@ interface Event {

  readonly attribute boolean bubbles;
  readonly attribute boolean cancelable;
+           attribute boolean returnValue;


Also historical? We have preventDefault() and defaultPrevented nowadays.

cvrebert · 2018-04-02T17:43:19Z

dom.bs

@@ -675,6 +680,12 @@ The <dfn attribute for=Event><code>bubbles</code></dfn> and
 <dfn attribute for=Event><code>cancelable</code></dfn> attributes
 must return the values they were initialized to.

+<p>The <dfn attribute for=Event><code>returnValue</code></dfn> attribute must be initialized to true
+when an <a>event</a> is created. When the attribute is set to false it must set the <a>canceled flag</a>


When the attribute is set to

Should be phrased as a setter instead?: "The returnValue attribute’s setter must [...]"

See cancelBubble for an example of the getter/setter boilerplate verbiage.

Yeah, I think phrasing this as a getter and setter (one paragraph each) (and not saying anything about initial state) would be best. The initial state doesn't really exist, since it just reflects the canceled flag.

miketaylr · 2018-04-05T22:46:05Z

Fixes #625. (References in titles don't create cross-references in GitHub.)

(once the commit lands it should, but thanks!)

miketaylr · 2018-04-05T23:04:34Z

r? @cvrebert @annevk

cvrebert · 2018-04-06T01:09:09Z

dom.bs

@@ -675,6 +680,12 @@ The <dfn attribute for=Event><code>bubbles</code></dfn> and
 <dfn attribute for=Event><code>cancelable</code></dfn> attributes
 must return the values they were initialized to.

+<p>The <dfn attribute for=Event><code>returnValue</code></dfn> attribute's getter must return false
+if the <a>canceled flag</a> is set, and true otherwise.


if the <a>canceled flag</a> is set

if <a>context object</a>'s <a>canceled flag</a> is set

cvrebert · 2018-04-06T01:09:56Z

dom.bs

+<p>The <dfn attribute for=Event><code>returnValue</code></dfn> attribute's getter must return false
+if the <a>canceled flag</a> is set, and true otherwise.
+
+<p>The {{Event/returnValue}} attribute's setter must, if the given value is false, set the <a>canceled flag</a>


set context object's canceled flag

cvrebert · 2018-04-06T01:11:55Z

dom.bs

+if the <a>canceled flag</a> is set, and true otherwise.
+
+<p>The {{Event/returnValue}} attribute's setter must, if the given value is false, set the <a>canceled flag</a>
+if the {{Event/cancelable}} attribute value is true and the <a>in passive listener flag</a> is unset.


context object's in passive listener flag

Also "the context object's {{Event/cancelable}} ..."

Although maybe it would be nicer to refactor this and make it share an algorithm with preventDefault(). I can do that before landing I suppose.

cvrebert · 2018-04-06T01:13:24Z

dom.bs

+if the <a>canceled flag</a> is set, and true otherwise.
+
+<p>The {{Event/returnValue}} attribute's setter must, if the given value is false, set the <a>canceled flag</a>
+if the {{Event/cancelable}} attribute value is true and the <a>in passive listener flag</a> is unset.


[...] and do nothing otherwise.

miketaylr · 2018-04-06T15:28:31Z

Changes made, thanks @annevk @cvrebert.

Unfortunately the web depends on these. They are intentionally defined in such a way to not offer capabilities beyond the non-historical API for events. Tests: web-platform-tests/wpt#10258. Fixes whatwg#625 and fixes whatwg#627.

annevk · 2018-04-09T08:49:36Z

I made a couple tweaks so this also fixes #627.

Do we have all the browser bugs that we need here?

I found https://bugs.chromium.org/p/chromium/issues/detail?id=277851 against Chrome, but it's not quite scoped to this (I left a comment).

For Firefox there's https://bugzilla.mozilla.org/show_bug.cgi?id=453968 for srcElement.

cvrebert · 2018-04-09T09:07:23Z

The other relevant Chrome bug is https://bugs.chromium.org/p/chromium/issues/detail?id=692695
Looks like we need a WebKit bug for changing its returnValue to be no more powerful than preventDefault() ?
I couldn't find a Mozilla bug for implementing returnValue.

annevk · 2018-04-09T09:19:18Z

Yeah, Edge and WebKit.

annevk · 2018-04-09T09:36:47Z

(Travis is complaining due to validator/validator#634 btw.)

annevk · 2018-04-09T09:48:08Z

Firefox bug for returnValue: https://bugzilla.mozilla.org/show_bug.cgi?id=1452569.

annevk · 2018-04-09T11:35:18Z

https://bugs.webkit.org/show_bug.cgi?id=184415 Reviewed by Darin Adler. LayoutTests/imported/w3c: Import test coverage from web-platform-tests/wpt#10258. * web-platform-tests/dom/events/AddEventListenerOptions-passive-expected.txt: * web-platform-tests/dom/events/AddEventListenerOptions-passive.html: * web-platform-tests/dom/events/Event-constructors.html: * web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch-expected.txt: * web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch.html: * web-platform-tests/dom/events/Event-defaultPrevented-expected.txt: * web-platform-tests/dom/events/Event-defaultPrevented.html: * web-platform-tests/dom/events/Event-dispatch-click.html: * web-platform-tests/dom/events/Event-dispatch-detached-click.html: * web-platform-tests/dom/events/Event-dispatch-other-document.html: * web-platform-tests/dom/events/Event-initEvent.html: * web-platform-tests/dom/events/Event-returnValue-expected.txt: Added. * web-platform-tests/dom/events/Event-returnValue.html: Added. * web-platform-tests/dom/events/EventListener-handleEvent.html: * web-platform-tests/dom/events/EventTarget-dispatchEvent-returnvalue-expected.txt: * web-platform-tests/dom/events/EventTarget-dispatchEvent-returnvalue.html: * web-platform-tests/dom/events/w3c-import.log: * web-platform-tests/dom/interfaces-expected.txt: * web-platform-tests/interfaces/dom.idl: Source/WebCore: Update Event.returnValue setter to match the latest DOM specification after: - whatwg/dom#626 In particular, the returnValue setter is now a no-op if the new flag value is true. If the input flag value is false, it only sets the 'canceled' flag if the event is cancelable and the event’s in passive listener flag is unset. Test: imported/w3c/web-platform-tests/dom/events/Event-returnValue.html * dom/Event.cpp: (WebCore::Event::setLegacyReturnValue): (WebCore::Event::setCanceledFlagIfPossible): (WebCore::Event::preventDefault): * dom/Event.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@230664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

These were added to the spec in whatwg/dom#626.

cvrebert suggested changes Apr 2, 2018

View reviewed changes

annevk mentioned this pull request Apr 5, 2018

Add window.event as a legacy compat requirement #407

Merged

miketaylr changed the title ~~Issue #625. Define Event.srcElement and Event.returnValue for compat.~~ Fixes #625. Define Event.srcElement and Event.returnValue for compat. Apr 5, 2018

miketaylr force-pushed the issues/625/1 branch from 7da8e8e to 7883839 Compare April 5, 2018 23:03

miketaylr force-pushed the issues/625/1 branch from 7883839 to ec01bff Compare April 5, 2018 23:07

cvrebert suggested changes Apr 6, 2018

View reviewed changes

annevk mentioned this pull request Apr 6, 2018

Flag refs in preventDefault()'s description missing "context object’s" qualifier #627

Closed

miketaylr force-pushed the issues/625/1 branch from ec01bff to a71ae13 Compare April 6, 2018 15:28

cvrebert approved these changes Apr 6, 2018

View reviewed changes

annevk force-pushed the issues/625/1 branch from a71ae13 to f0254b6 Compare April 9, 2018 08:41

Define Event's srcElement and returnValue

f6eb0e0

Unfortunately the web depends on these. They are intentionally defined in such a way to not offer capabilities beyond the non-historical API for events. Tests: web-platform-tests/wpt#10258. Fixes whatwg#625 and fixes whatwg#627.

annevk force-pushed the issues/625/1 branch from f0254b6 to f6eb0e0 Compare April 9, 2018 08:42

annevk changed the title ~~Fixes #625. Define Event.srcElement and Event.returnValue for compat.~~ Define Event.srcElement and Event.returnValue Apr 9, 2018

annevk merged commit e36b369 into whatwg:master Apr 9, 2018

Zirro added a commit to Zirro/jsdom that referenced this pull request Apr 16, 2018

Implement srcElement and returnValue for Event

8551af1

These were added to the spec in whatwg/dom#626.

Zirro added a commit to Zirro/jsdom that referenced this pull request Apr 23, 2018

Implement srcElement and returnValue for Event

baeb4b6

These were added to the spec in whatwg/dom#626.

Zirro added a commit to Zirro/jsdom that referenced this pull request Apr 25, 2018

Implement srcElement and returnValue for Event

9ef08a2

These were added to the spec in whatwg/dom#626.

domenic pushed a commit to jsdom/jsdom that referenced this pull request Apr 26, 2018

Implement srcElement and returnValue for Event

571cd9f

These were added to the spec in whatwg/dom#626.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Define Event.srcElement and Event.returnValue #626

Define Event.srcElement and Event.returnValue #626

miketaylr commented Mar 30, 2018 •

edited by pr-preview bot

Loading

cvrebert commented Apr 2, 2018

cvrebert Apr 2, 2018

cvrebert Apr 2, 2018

annevk Apr 3, 2018

miketaylr commented Apr 5, 2018

miketaylr commented Apr 5, 2018

cvrebert Apr 6, 2018

cvrebert Apr 6, 2018

cvrebert Apr 6, 2018

annevk Apr 6, 2018

annevk Apr 6, 2018

cvrebert Apr 6, 2018

miketaylr commented Apr 6, 2018

annevk commented Apr 9, 2018

cvrebert commented Apr 9, 2018 •

edited

Loading

annevk commented Apr 9, 2018

annevk commented Apr 9, 2018

annevk commented Apr 9, 2018

annevk commented Apr 9, 2018

Define Event.srcElement and Event.returnValue #626

Define Event.srcElement and Event.returnValue #626

Conversation

miketaylr commented Mar 30, 2018 • edited by pr-preview bot Loading

cvrebert commented Apr 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miketaylr commented Apr 5, 2018

miketaylr commented Apr 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miketaylr commented Apr 6, 2018

annevk commented Apr 9, 2018

cvrebert commented Apr 9, 2018 • edited Loading

annevk commented Apr 9, 2018

annevk commented Apr 9, 2018

annevk commented Apr 9, 2018

annevk commented Apr 9, 2018

miketaylr commented Mar 30, 2018 •

edited by pr-preview bot

Loading

cvrebert commented Apr 9, 2018 •

edited

Loading