Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

same-origin/cors requests and opaqueredirect #1145

Closed
wanderview opened this issue Jan 22, 2021 · 4 comments
Closed

same-origin/cors requests and opaqueredirect #1145

wanderview opened this issue Jan 22, 2021 · 4 comments

Comments

@wanderview
Copy link
Member

I'm sorry if we've discussed this before, but what is the motivation for hiding manual redirect responses for same-origin/cors requests behind an opaqueredirect filtered response? It seems for same-origin and cors it should be ok to know the status and location header.

For additional context, hiding the data in an opaque-style response has additional costs when stored in the cache API. To avoid leaking information through the storage.estimate() API generally these responses have to be padded out with a large amount of quota space. This seems very punitive for same-origin and cors responses.

@wanderview
Copy link
Member Author

I guess navigate requests are where manual redirect mode is normally used. Those are essentially "same-origin", but since they are a navigation don't have any primary context to be cross-origin from.

In that case, though, the service worker is by definition same origin to the opaqueredirect URL. I still don't understand why we have to hide the location header from the same origin that produced the location header.

@annevk
Copy link
Member

annevk commented Jan 22, 2021

@wanderview
Copy link
Member Author

Hmm, ok. Thanks.

@annevk
Copy link
Member

annevk commented Jan 22, 2021

See #601 for an opt-in approach to exposing them anyway, but I suspect that was not your motivation for filing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants