Skip to content

Commit

Permalink
First round of review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
@jgraham
jgraham committed May 14, 2021
1 parent 57ca2a1 commit cd5e9fc
Showing 1 changed file with 39 additions and 28 deletions.
67 changes: 39 additions & 28 deletions source
View file
Original file line number Diff line number Diff line change
Expand Up @@ -85415,7 +85415,7 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
<dd>The URL which is being loaded in the navigation</dd>
</dl>

<p class="note">The navigation hooks have been designed with the WebDriver-BiDi
<p class="note">The navigation hooks have been designed with the WebDriver BiDi
specification in mind. These might need to be adjusted for other use cases.
<ref spec="WEBDRIVERBIDI"></p>

Expand Down Expand Up @@ -85497,15 +85497,12 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
non-null, then:</p>

<ol>
<li><p><span data-x="navigate-fragid">Navigate to a fragment</span> given
<var>browsingContext</var>, <var>resource</var>'s <span
data-x="concept-request-url">url</span>, and <var>historyHandling</var>.</p></li>

<li><p>Return a new <span>navigation status</span> whose <span
data-x="navigation-status-id">id</span> is null, <span data-x="navigation-status-url">url</span>
is <var>resource</var>'s <span data-x="concept-request-url">url</span>, and <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-complete">complete</code>".</p></li>
<li><p>Let <var>navigationStatus</var> be the result of <span
data-x="navigate-fragid">Navigate to a fragment</span> given <var>browsingContext</var>,
<var>resource</var>'s <span data-x="concept-request-url">url</span>, and
<var>historyHandling</var>.</p></li>

<li><p>Return <var>navigationStatus</var>.</p></li>
</ol>
</li>

Expand Down Expand Up @@ -85594,7 +85591,6 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
id</var> be the string representation of a UUID based on truly random, or pseudo-random numbers
<ref spec=RFC4122></p>


<li><p>Let <var>navigationStatus</var> be a new <span>navigation status</span>
whose <span data-x="navigation-status-id">id</span> is <var>navigationId</var>,
<span data-x="navigation-status-url">url</span> is <var>resource</var>'s <span
Expand All @@ -85605,7 +85601,7 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
specifications</span> with <var>navigationStatus</var>.</p></li>

<li><p>Return <var>navigationStatus</var>, and continue running these steps
<span>in parallel</span></p>.</li>
<span>in parallel</span>.</p></li>

<li>
<p>This is the step that attempts to obtain <var>resource</var>, if necessary. Jump to the first
Expand Down Expand Up @@ -86149,7 +86145,7 @@ interface <dfn>Location</dfn> { // but see also <a href="#the-location-interface
<li><p>Run any <dfn>download started steps</dfn> defined by <span>other applicable
specifications</span> with a new <span>navigation status</span> whose
<span data-x="navigation-status-id">id</span> is <var>navigtionParams</var>'
<span data-x="navigation-params-id">id</span>,<span data-x="navigation-status-status"
<span data-x="navigation-params-id">id</span>, <span data-x="navigation-status-status"
>status</span> is "<code data-x="navigation-status-complete">complete</code>", and <span
data-x="navigation-status-url">url</span> is <var>response</var>'s <span
data-x="concept-response-url">URL</span>.</p></li>
Expand Down Expand Up @@ -86861,10 +86857,10 @@ new PaymentRequest(&hellip;); // Allowed to use
<var>navigationParams</var> and a string <var>type</var>, user agents must follow the requirements
defined in <cite>XML</cite> and <cite>Namespaces in XML</cite>, <cite>XML Media Types</cite>,
<cite>DOM</cite>, and other relevant specifications to <span
data-x="create-the-document-object">create and initialize a <code>Document</code> object</span>
given "<code data-x="">xml</code>", <var>type</var>, and <var>navigationParams</var>. They must
also create a corresponding <span>XML parser</span>. <ref spec=XML> <ref spec=XMLNS> <ref
spec=RFC7303> <ref spec=DOM></p>
data-x="create-the-document-object">create and initialize a <code>Document</code> object</span>,
<var>document</var> given "<code data-x="">xml</code>", <var>type</var>, and
<var>navigationParams</var>. They must also create a corresponding <span>XML parser</span>.
<ref spec=XML> <ref spec=XMLNS> <ref spec=RFC7303> <ref spec=DOM></p>

<p class="note">At the time of writing, the XML specification community had not actually yet
specified how XML and the DOM interact.</p> <!--XMLPARSE-->
Expand All @@ -86875,16 +86871,17 @@ new PaymentRequest(&hellip;); // Allowed to use
encoding is established, the <span>document's character encoding</span> must be set to that
character encoding.</p>

<p>Then, with the newly created <code>Document</code>, the user agent must <span>update the
session history with the new page</span> given <var>navigationParams</var> and the newly-created
<code>Document</code>. User agents may do this before the complete document has been parsed (thus
achieving <i>incremental rendering</i>), and must do this before any scripts are to be
executed.</p>
<p>Then, with <var>document</var>, the user agent must <span>update the session history with the
new page</span> given <var>navigationParams</var> and <var>document</var>. User agents may do
this before the complete document has been parsed (thus achieving <i>incremental rendering</i>),
and must do this before any scripts are to be executed.</p>

<li><p>Once parsing is complete, the user agent must set <var>document</var>'s <span
data-x="concept-document-navigation-id">navigation id</span> to null.</p></li>

<p>Error messages from the parse process (e.g., XML namespace well-formedness errors) may be
reported inline by mutating the <code>Document</code>.</p>


<h4 id="read-text"><dfn data-x="navigate-text">Page load processing model for text files</dfn></h4>

<p>When a plain text document is to be loaded, provided <span>navigation params</span>
Expand Down Expand Up @@ -87155,6 +87152,17 @@ new PaymentRequest(&hellip;); // Allowed to use
<var><span>nonBlockingEvents</span></var> set to true. This will <span>scroll to the
fragment</span> given in what is now the document's <span
data-x="concept-document-url">URL</span>.</p></li>

<li><p>Let <var>navigationStatus</var> be a new <span>navigation status</span> whose <span
data-x="navigation-status-id">id</span> is null, <span data-x="navigation-status-url">url</span>
is <var>resource</var>'s <span data-x="concept-request-url">url</span>, and <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-complete">complete</code>".</p></li>

<li><p>Run any <dfn>fragment navigated steps</dfn> defined by <span>other applicable
specifications</span> with <var>navigationStatus</var>.</p></li>

<li><p>Return <var>navigationStatus</var>.</p></li>
</ol>

<p class="note">If the scrolling fails because the relevant <span data-x="concept-id">ID</span> has
Expand Down Expand Up @@ -88015,12 +88023,15 @@ interface <dfn>BeforeUnloadEvent</dfn> : <span>Event</span> {

<li><p>Set <var>document</var>'s <i data-x="concept-document-salvageable">salvageable</i> state
to false.</p></li>

<li><p>Set <var>document</var>'s <span data-x="concept-document-navigation-id">navigation
id</span> to null.</p></li>
</ol>
</li>

<li>
<p>If <var>document</var> has a non null <span
data-x="concept-document-navigation-id">navigation id</span>, then:</p>
<p>If <var>document</var>'s <span data-x="concept-document-navigation-id">navigation id</span>
is non-null, then:</p>

<ol>
<li><p>Run any <span data-x="navigation failed steps">navigation failed steps</span> defined by
Expand Down Expand Up @@ -112595,7 +112606,7 @@ document.body.appendChild(text);
data-x="serviceworkercontainer-service-worker-client">service worker client</span> is the
<code>Document</code> object's <span>relevant settings object</span>.</p></li>

<li><p>Call any <dfn>DOM load complete steps</dfn> defined in <span>other applicable
<li><p>Call any <dfn>DOM content loaded steps</dfn> defined in <span>other applicable
specifications</span> with a new <span>navigation status</span> whose <span
data-x="navigation-status-id">id</span> is the <code>Document</code> object's <span
data-x="concept-document-navigation-id">navigation id</span>, <span
Expand Down Expand Up @@ -112641,7 +112652,7 @@ document.body.appendChild(text);
time</span> to the <span>current high resolution time</span> given the
<code>Document</code>'s <span>relevant global object</span>.</p></li>

<li><p>Call any <dfn>load complete steps</dfn>defined in <span>other applicable
<li><p>Call any <dfn>load complete steps</dfn> defined in <span>other applicable
specifications</span> with a new <span>navigation status</span> whose <span
data-x="navigation-status-id">id</span> is the <code>Document</code> object's <span
data-x="concept-document-navigation-id">navigation id</span>, <span
Expand Down Expand Up @@ -124413,7 +124424,7 @@ INSERT INTERFACES HERE
<dd>(Non-normative) <cite><a href="https://w3c.github.io/webcrypto/Overview.html">Web Cryptography API</a></cite>, M. Watson. W3C.</dd>

<dt id="refsWEBDRIVERBIDI">[WEBDRIVERBIDI]</dt>
<dd>(Non-normative) <cite><a href="https://w3c.github.io/webdriver-bidi/">WebDriver BiDi</a></cite>. W3C</dd>
<dd><cite><a href="https://w3c.github.io/webdriver-bidi/">WebDriver BiDi</a></cite>. W3C</dd>

<dt id="refsWEBGL">[WEBGL]</dt>
<dd><cite><a href="https://www.khronos.org/registry/webgl/specs/latest/">WebGL Specifications</a></cite>, D. Jackson, J. Gilbert. Khronos Group.</dd>
Expand Down

0 comments on commit cd5e9fc

Please sign in to comment.