Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove input[type=datetime] #336

Closed
tkent-google opened this issue Nov 13, 2015 · 18 comments
Closed

Remove input[type=datetime] #336

tkent-google opened this issue Nov 13, 2015 · 18 comments

Comments

@tkent-google
Copy link
Collaborator

@tkent-google tkent-google commented Nov 13, 2015

https://html.spec.whatwg.org/multipage/forms.html#date-and-time-state-(type=datetime)

Because there is no implementation now though Presto Opera had it.
We don't have a plan to implement it in Blink.

Presto: All input types were supported.
Blink: datetime is not supported.
Edge 13.10586: datetime is not supported.
Mobile Safari: datetime is not supported.
Mobile Firefox: month, week, datetime, and datetime-local are not supported.
Desktop Safari: date, datetime, datetime-local, month, time, and week are not supported.
Desktop Firefox: date, datetime, datetime-local, month, time, and week are not supported.

@annevk
Copy link
Member

@annevk annevk commented Nov 13, 2015

I guess it's too late to rename datetime-local to datetime. Bit of a shame. Would making them an alias work?

@foolip
Copy link
Member

@foolip foolip commented Nov 14, 2015

Relevant use counters:

Both are counted only when the computed style is is not visibility:hidden. (Not sure why, there are many other ways to not be visible.)

@annevk
Copy link
Member

@annevk annevk commented Nov 15, 2015

From that it seems that neither is really used. @hober, do you have views on this? @travisleithead?

@tkent-google
Copy link
Collaborator Author

@tkent-google tkent-google commented Nov 15, 2015

We received multiple bug reports when we introduced a regression of input[type=datetime-local] in Blink. So, I think it has real users, and we won't remove it.

@annevk
Copy link
Member

@annevk annevk commented Nov 16, 2015

Alright, I guess removing datetime first would be good. We can always reconsider later if we want to make it an alias for datetime-local.

annevk added a commit that referenced this issue Nov 25, 2015
@annevk annevk closed this in 80ba4fa Nov 26, 2015
@tkent-google
Copy link
Collaborator Author

@tkent-google tkent-google commented Nov 26, 2015

😄 Thanks!

@annevk
Copy link
Member

@annevk annevk commented Nov 26, 2015

Thank you for the suggestion!

@stuartpb
Copy link

@stuartpb stuartpb commented Dec 1, 2015

What's the new (existing) suggested best practice for unambiguous time point entry now? Have a datetime-local alongside a dropdown for picking the time zone?

@foolip
Copy link
Member

@foolip foolip commented Dec 1, 2015

That or an entirely custom component, I guess.

@domenic
Copy link
Member

@domenic domenic commented Dec 1, 2015

FWIW that's what Outlook does :)
timezone dropdown

@annevk
Copy link
Member

@annevk annevk commented Dec 7, 2015

Google Calendar does the same. Seems good enough.

cvrebert added a commit to twbs/bootstrap that referenced this issue Jan 6, 2016
It has been removed from the HTML specification: whatwg/html#336
Only Presto Opera ever implemented a special UI for it.

[skip sauce]
@rvklein
Copy link

@rvklein rvklein commented Feb 10, 2016

Great, now we don't have a future option for unambiguous TZ datetime input. Thanks a lot.

@annevk
Copy link
Member

@annevk annevk commented Feb 11, 2016

I don't quite understand what you mean. Removal from the standard does not stop it from being introduced again at some point in the future.

@rvklein
Copy link

@rvklein rvklein commented Feb 12, 2016

@annevk : It's likely my fault for misunderstanding the WHATWG process for these issues. Regardless, apologies for the sarcasm.

@annevk
Copy link
Member

@annevk annevk commented Feb 13, 2016

https://wiki.whatwg.org/wiki/FAQ#Is_there_a_process_for_removing_bad_ideas_from_a_specification.3F should explain the rationale. Basically, if something is not implemented and there is no desire to implement, we remove it. This happens at times. We've started being a lot more careful about adding new features though, so it should happen less going forward.

@Sorumeiji
Copy link

@Sorumeiji Sorumeiji commented Jun 22, 2016

With datetime removed, this pretty much changes forums optimization a lot doesn't it? Its adding a another question or input. I am fine with this, but I don't see why to remove something useful.

@domenic
Copy link
Member

@domenic domenic commented Jun 22, 2016

Since it wasn't implemented anywhere, I have a hard time seeing how it changes anything.

@Sorumeiji
Copy link

@Sorumeiji Sorumeiji commented Jun 22, 2016

True, I just read more into the MDN docs. I forgot there is "time", so I am guessing that's used more. Sorry about that.

cvrebert added a commit to twbs/bootstrap that referenced this issue Jul 22, 2016
* <input type="datetime"> no longer exists, per whatwg/html#336
* iOS 9.3.2 still doesn't support <input type="week">

[skip sauce]
[skip validator]
cvrebert added a commit to twbs/bootstrap that referenced this issue Jul 22, 2016
* <input type="datetime"> no longer exists, per whatwg/html#336
* iOS 9.3.2 still doesn't support <input type="week">

[skip sauce]
[skip validator]
cvrebert added a commit to web-platform-tests/wpt that referenced this issue Jan 19, 2017
Because input[type=datetime] was removed from the specification in
whatwg/html#336
domenic added a commit to web-platform-tests/wpt that referenced this issue Jan 20, 2017
Because input[type=datetime] was removed from the specification in
whatwg/html#336
disconsented referenced this issue in WaikatoUniMM2017/COMP315 Oct 1, 2017
Updated wrong html file... This is the updated version done 4/15
Menu
Add Players
Add Teams
New Tournament

Date Time picker and image not working also menu not linked up with corresponding menu items
jonleighton added a commit to jonleighton/servo that referenced this issue Dec 7, 2017
bors-servo added a commit to servo/servo that referenced this issue Dec 7, 2017
Remove support for <input type=datetime>

It has been removed from the spec: whatwg/html#336

See also #19471 (review)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19509)
<!-- Reviewable:end -->
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Dec 8, 2017
…jonleighton:remove-input-type-datetime); r=jdm

It has been removed from the spec: whatwg/html#336

See also servo/servo#19471 (review)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e3056d0cc7caebc218d51373b3aa0ccd331fa20

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 76bd32c1d97be56bee2675857fcb5b20f2ed2d42
xeonchen pushed a commit to xeonchen/gecko-cinnabar that referenced this issue Dec 8, 2017
…jonleighton:remove-input-type-datetime); r=jdm

It has been removed from the spec: whatwg/html#336

See also servo/servo#19471 (review)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e3056d0cc7caebc218d51373b3aa0ccd331fa20
aethanyc pushed a commit to aethanyc/gecko-dev that referenced this issue Dec 19, 2017
…jonleighton:remove-input-type-datetime); r=jdm

It has been removed from the spec: whatwg/html#336

See also servo/servo#19471 (review)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 8e3056d0cc7caebc218d51373b3aa0ccd331fa20
chiraggmodi pushed a commit to chiraggmodi/bootstrap that referenced this issue Apr 8, 2019
* <input type="datetime"> no longer exists, per whatwg/html#336
* iOS 9.3.2 still doesn't support <input type="week">

[skip sauce]
[skip validator]
Levure added a commit to Levure/symfony-docs that referenced this issue May 29, 2020
Changed the html5 input type for DateTimeType to datetime-local (which is the html5 input type) instead of the datetime input type.

The datetime input type field has been removed from WHATWG HTML (whatwg/html#336)
The datetime-local input type is the type used for rendering DateTimeType when html5 option is set to true.
javiereguiluz added a commit to symfony/symfony-docs that referenced this issue May 29, 2020
This PR was merged into the 3.4 branch.

Discussion
----------

Fix typo of HTML5 field type for DateTimeType

Changed the html5 input type for DateTimeType to datetime-local (which is the html5 input type) instead of the datetime input type.

- The **datetime** input type field has been removed from WHATWG HTML (whatwg/html#336)
- The **datetime-local** input type is the type used for rendering DateTimeType when html5 option is set to true.

Commits
-------

dd1749a Fix typo of HTML5 field type for DateTimeType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants