Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "search" event #667

Open
cvrebert opened this issue Feb 10, 2016 · 12 comments
Open

The "search" event #667

cvrebert opened this issue Feb 10, 2016 · 12 comments
Assignees
@miketaylr
Labels
compat Standard is not web compatible or proprietary feature needs standardizing

Comments

@cvrebert
Copy link
Member

WebKit and Blink fire a search event at <input type="search">es in certain cases. See https://developer.mozilla.org/en-US/docs/Web/Events/search
Trivial example: http://jsbin.com/julilo/1/edit?html,js,output
This event doesn't currently seem to be spec'd anywhere, and I was unable to find any previous WHATWG/W3C discussions regarding it.
@annevk
Copy link
Member

annevk commented Feb 10, 2016

@miketaylr, is this important for interop?

@miketaylr
Copy link
Member

Will look into it.

@zcorpan zcorpan added the compat Standard is not web compatible or proprietary feature needs standardizing label Feb 11, 2016
@cvrebert
Copy link
Member Author

cvrebert commented Feb 7, 2017

@miketaylr Any findings?

@cvrebert
Copy link
Member Author

(Relevant Chrome code: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/forms/SearchInputType.cpp?l=125&rcl=2fbfd7490c876078719caf9867575b9a0826b2ba )

@cvrebert
Copy link
Member Author

Related Chrome bug: https://crbug.com/690143

@leobalter
Copy link

I'd like to work on this issue, is anyone else already working on it?

@leobalter
Copy link

So, following the last link for the Chrome bug, I've noticed it's actually being deprecated and removed there, basically on the rejection reported here: https://lists.w3.org/Archives/Public/public-whatwg-archive/2008Nov/0403.html

I wonder if the correct solution is to not spec the search event. So my work here is stalled for now until further decision.

@annevk
Copy link
Member

annevk commented Mar 15, 2019

So the status is that Chrome and Safari ship this and @tkent-google is looking into removing it from Chrome. I guess it hasn't come up as a problem for Firefox or @miketaylr would have said something. Based on that I suppose we still want to get rid of this.

It might make sense to add "historical" tests to ensure the incremental attribute, the search event, and the onsearch event handler are not supported.

@leobalter
Copy link

Thanks for the update! From this point I'd like to take a look at the tests and see if I can add anything.

@miketaylr
Copy link
Member

@miketaylr Any findings?

👀

@miketaylr would have said something.

Yeah, sorry, lost track of this.

This has not surfaced as an important DOM event for compat, at least we don't know of significant bustage due to not having this in Gecko.

@jugglinmike
Copy link
Contributor

Reported to the WebKit maintainers here:

https://bugs.webkit.org/show_bug.cgi?id=195818

@jugglinmike jugglinmike mentioned this issue May 23, 2019
Closed
zcorpan added a commit to web-platform-tests/wpt that referenced this issue Oct 25, 2019
@zcorpan
HTML: Add a historical test for the search event and incremental=""
4f0b192 
See whatwg/html#667
@zcorpan zcorpan mentioned this issue Oct 25, 2019
Merged
zcorpan added a commit to web-platform-tests/wpt that referenced this issue Oct 29, 2019
@zcorpan
HTML: Add a historical test for the search event and incremental=""
3b93e83 
See whatwg/html#667
@zcorpan
Copy link
Member

zcorpan commented Oct 29, 2019

Tests for non-support were added in web-platform-tests/wpt#19889 (merged just now).

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 20, 2019
@zcorpan @moz-wptsync-bot
Bug 1591442 [wpt PR 19889] - HTML: Add a historical test for the sear…
cfdd63f 
…ch event and incremental="", a=testonly

Automatic update from web-platform-tests
HTML: Add a historical test for the search event and incremental=""

See whatwg/html#667
--

wpt-commits: 3b93e8373d4091fea282bb6ae7bb0e655fe3ecd5
wpt-pr: 19889

Differential Revision: https://phabricator.services.mozilla.com/D53544
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Nov 20, 2019
@zcorpan @moz-wptsync-bot
Bug 1591442 [wpt PR 19889] - HTML: Add a historical test for the sear…
1f96d62 
…ch event and incremental="", a=testonly

Automatic update from web-platform-tests
HTML: Add a historical test for the search event and incremental=""

See whatwg/html#667
--

wpt-commits: 3b93e8373d4091fea282bb6ae7bb0e655fe3ecd5
wpt-pr: 19889

Differential Revision: https://phabricator.services.mozilla.com/D53544
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 21, 2019
@marco-c
Bug 1591442 [wpt PR 19889] - HTML: Add a historical test for the sear…
89b4892 
…ch event and incremental="", a=testonly

Automatic update from web-platform-tests
HTML: Add a historical test for the search event and incremental=""

See whatwg/html#667
--

wpt-commits: 3b93e8373d4091fea282bb6ae7bb0e655fe3ecd5
wpt-pr: 19889

Differential Revision: https://phabricator.services.mozilla.com/D53544

UltraBlame original commit: 359d207cc82cf56700f1ab68ce644639d34a2a6a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 21, 2019
@marco-c
Bug 1591442 [wpt PR 19889] - HTML: Add a historical test for the sear…
352cba1 
…ch event and incremental="", a=testonly

Automatic update from web-platform-tests
HTML: Add a historical test for the search event and incremental=""

See whatwg/html#667
--

wpt-commits: 3b93e8373d4091fea282bb6ae7bb0e655fe3ecd5
wpt-pr: 19889

Differential Revision: https://phabricator.services.mozilla.com/D53544

UltraBlame original commit: 359d207cc82cf56700f1ab68ce644639d34a2a6a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 21, 2019
@marco-c
Bug 1591442 [wpt PR 19889] - HTML: Add a historical test for the sear…
15903a5 
…ch event and incremental="", a=testonly

Automatic update from web-platform-tests
HTML: Add a historical test for the search event and incremental=""

See whatwg/html#667
--

wpt-commits: 3b93e8373d4091fea282bb6ae7bb0e655fe3ecd5
wpt-pr: 19889

Differential Revision: https://phabricator.services.mozilla.com/D53544

UltraBlame original commit: 359d207cc82cf56700f1ab68ce644639d34a2a6a
@Ahmad-S792 Ahmad-S792 mentioned this issue Jun 6, 2023
Closed
Ahmad-S792 added a commit to Ahmad-S792/WebKit that referenced this issue Jun 7, 2023
@Ahmad-S792
Remove non-standard 'incremental' attribute
a77f60e 
https://bugs.webkit.org/show_bug.cgi?id=257686

Reviewed by NOBODY (OOPS!).

This patch aligns WebKit with Gecko / Firefox by removing non-standard
'incremental' attribute on Inputs.

Issue: whatwg/html#667

* Source/WebCore/html/HTMLInputElement.idl: Remove 'incremental'
* Source/WebCore/html/HTMLInputElement.cpp: Remove 'incremental' usage
* Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:
((BOOL) incremental): Delete function
((void)setIncremental:(BOOL)newIncremental): Ditto
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/historical-expected.txt: Rebaselined
* LayoutTests/fast/forms/incremental-dom-property.html: Deleted
* LayoutTests/fast/forms/incremental-dom-property-expected.txt: Deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
compat Standard is not web compatible or proprietary feature needs standardizing
Milestone
No milestone
Development

No branches or pull requests
6 participants
@miketaylr @zcorpan @leobalter @cvrebert @jugglinmike @annevk