HTML: Add a historical test for the search event and incremental="" #19889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
annevk,
domenic,
jdm,
jgraham,
tkent-google and
zqzhang
domenic
reviewed
Oct 25, 2019
Member
Author
domenic
approved these changes
Oct 25, 2019
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
LGTM as tests, and I guess we should feel free to merge tests that reflect the current spec. But it's not clear to me what the future is for these; in particular the search event seems like it might need to get specced based on the use counter discussions.
Member
Author
|
@tkent-google do you think this should be merged now or wait until we know if removal is successful? |
tkent-google
approved these changes
Oct 28, 2019
Contributor
tkent-google
left a comment
tkent-google
left a comment
There was a problem hiding this comment.
do you think this should be merged now or wait until we know if removal is successful?
I think Chrome can remove them, and we can merge this PR now.
Member
Author
|
Thanks @tkent-google |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#667