Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: Add a historical test for the search event and incremental="" #19889

Merged
merged 2 commits into from Oct 29, 2019

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Oct 25, 2019

@zcorpan
Copy link
Member Author

zcorpan commented Oct 25, 2019

Copy link
Member

@domenic domenic left a comment

LGTM as tests, and I guess we should feel free to merge tests that reflect the current spec. But it's not clear to me what the future is for these; in particular the search event seems like it might need to get specced based on the use counter discussions.

@zcorpan
Copy link
Member Author

zcorpan commented Oct 25, 2019

@tkent-google do you think this should be merged now or wait until we know if removal is successful?

@zcorpan zcorpan assigned tkent-google and unassigned zqzhang Oct 25, 2019
Copy link
Contributor

@tkent-google tkent-google left a comment

do you think this should be merged now or wait until we know if removal is successful?

I think Chrome can remove them, and we can merge this PR now.

@zcorpan zcorpan merged commit 3b93e83 into master Oct 29, 2019
@zcorpan zcorpan deleted the zcorpan/historical-onsearch branch Oct 29, 2019
@zcorpan
Copy link
Member Author

zcorpan commented Oct 29, 2019

Thanks @tkent-google

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants