Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct URL parsing of base elements #1064

Merged
merged 2 commits into from
Apr 20, 2016
Merged

Correct URL parsing of base elements #1064

merged 2 commits into from
Apr 20, 2016

Conversation

annevk
Copy link
Member

@annevk annevk commented Apr 18, 2016

Fixes #1060.

mikewest
mikewest reviewed Apr 18, 2016
View reviewed changes
source
attribute, then return the <span>document base URL</span> and abort these steps.</p></li>
<ol>
<li><p>If this element has a <span>frozen base URL</span>, return it, <span
data-x="concept-url-serialiser">serialised</span>.</p></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "return its serialization" sounds a little better to my ear.

@annevk
Make the getter always reflect the URL of the element, irrespective o…
76db6bb 
…f CSP and align with Gecko's and "reflect"'s error handling
@annevk
Copy link
Member Author

annevk commented Apr 19, 2016

Thanks @mikewest. @zcorpan, could you give this a final review? See also the original issue for motivation for these changes.

I'd like to merge this myself to create a clear commit message. When doing so.

@zcorpan
Copy link
Member

zcorpan commented Apr 19, 2016

LGTM

@annevk annevk merged commit 2719a51 into master Apr 20, 2016
@annevk annevk deleted the baseurlparsing branch April 20, 2016 05:59
domenic added a commit to jsdom/jsdom that referenced this pull request May 24, 2016
@domenic
Fix baseElement.href getter and other URL things for spec updates
ea6a0e5 
See whatwg/html#1064 (normative change) and whatwg/html#652 (editorial change).

This also fixes the referrer for resource loads to be the document's URL, not the document base URL.
nhunzaker pushed a commit to nhunzaker/jsdom that referenced this pull request Dec 22, 2016
@domenic @nhunzaker
Fix baseElement.href getter and other URL things for spec updates
3d06060 
See whatwg/html#1064 (normative change) and whatwg/html#652 (editorial change).

This also fixes the referrer for resource loads to be the document's URL, not the document base URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@annevk @zcorpan @mikewest