-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "child text content" to check if a <script> is empty #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches 2/4 implementations, and is simpler and integrates better with the rest of the algorithm. Closes #3419.
domenic
added
normative change
topic: script
interop
Implementations are not interoperable with each other
labels
Feb 5, 2018
domenic
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 5, 2018
zcorpan
approved these changes
Feb 12, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 1, 2018
…script element, a=testonly Automatic update from web-platform-testsAdd tests for already-started + emptyish script element Follows whatwg/html#3451. wpt-commits: 9354b7ca6002e7d6351fa352440e6468e69c9eee wpt-pr: 9396 wpt-commits: 9354b7ca6002e7d6351fa352440e6468e69c9eee wpt-pr: 9396
Chromium is fixed (https://bugs.chromium.org/p/chromium/issues/detail?id=811315). |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…script element, a=testonly Automatic update from web-platform-testsAdd tests for already-started + emptyish script element Follows whatwg/html#3451. wpt-commits: 9354b7ca6002e7d6351fa352440e6468e69c9eee wpt-pr: 9396 wpt-commits: 9354b7ca6002e7d6351fa352440e6468e69c9eee wpt-pr: 9396 UltraBlame original commit: 5934ad626211bca36c6885743f34c864d2bb76b8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
…script element, a=testonly Automatic update from web-platform-testsAdd tests for already-started + emptyish script element Follows whatwg/html#3451. wpt-commits: 9354b7ca6002e7d6351fa352440e6468e69c9eee wpt-pr: 9396 wpt-commits: 9354b7ca6002e7d6351fa352440e6468e69c9eee wpt-pr: 9396 UltraBlame original commit: 5934ad626211bca36c6885743f34c864d2bb76b8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
…script element, a=testonly Automatic update from web-platform-testsAdd tests for already-started + emptyish script element Follows whatwg/html#3451. wpt-commits: 9354b7ca6002e7d6351fa352440e6468e69c9eee wpt-pr: 9396 wpt-commits: 9354b7ca6002e7d6351fa352440e6468e69c9eee wpt-pr: 9396 UltraBlame original commit: 5934ad626211bca36c6885743f34c864d2bb76b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches 2/4 implementations, and is simpler and integrates better
with the rest of the algorithm.
Closes #3419.
Tests: web-platform-tests/wpt#9396
/scripting.html ( diff )