Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML parser: handle </br> and </p> in SVG #6736

Merged
merged 1 commit into from
Jun 23, 2021
Merged

HTML parser: handle </br> and </p> in SVG #6736

merged 1 commit into from
Jun 23, 2021

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jun 4, 2021 •
edited by pr-preview bot

Fixes #5113.

(See WHATWG Working Mode: Changes for more details.)

/parsing.html ( diff )

zcorpan added a commit to html5lib/html5lib-tests that referenced this pull request Jun 4, 2021
@zcorpan
Test </p> and </br> in SVG
c7fc3f6 
See whatwg/html#6736
@zcorpan zcorpan mentioned this pull request Jun 4, 2021
Merged
@zcorpan
Copy link
Member Author

zcorpan commented Jun 4, 2021

Together with #6455, I believe this matches current Chromium. @mfreed7 can you confirm?

@mfreed7
Copy link
Contributor

mfreed7 commented Jun 4, 2021

I think that's right. In Chromium, <table><math><p>foo gives me <math><p><table> in DOM. That's the correct check, right?

@zcorpan
Copy link
Member Author

zcorpan commented Jun 4, 2021

For #6455, yes. This PR is about these cases:

http://software.hixie.ch/utilities/js/live-dom-viewer/saved/9362

<svg></p><foo>

should produce:

  • html html
    • html head
    • html body
      • svg svg
      • html p
      • html foo

and

<svg></br><foo>

should produce:

  • html html
    • html head
    • html body
      • svg svg
      • html br
      • html foo

@mfreed7
Copy link
Contributor

mfreed7 commented Jun 7, 2021

Thanks. I can confirm that behavior in Chromium also. 😄

@zcorpan
Copy link
Member Author

zcorpan commented Jun 7, 2021

This matches Gecko as well for the non-fragment case. (The fragment case is different because Gecko doesn't yet implement #6399 + #6455.) cc @hsivonen

@gsnedders does this comment #5113 (comment) indicate implementer interest for WebKit?

Ms2ger pushed a commit to html5lib/html5lib-tests that referenced this pull request Jun 11, 2021
@zcorpan
Test </p> and </br> in SVG (#135)
9b4a29c 
See whatwg/html#6736
@domenic domenic added compat Standard is not web compatible or proprietary feature needs standardizing interop Implementations are not interoperable with each other normative change topic: parser labels Jun 14, 2021
@bathos bathos mentioned this pull request Jun 19, 2021
Closed
domenic
domenic approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simon, should we merge this? Aligning the spec with 2/3 implementations seems good!

@zcorpan
Copy link
Member Author

zcorpan commented Jun 23, 2021

I think it's good to merge, yeah

@domenic domenic merged commit 681c884 into main Jun 23, 2021
@domenic domenic deleted the bocoup/svg-br-p-end-tag branch June 23, 2021 23:09
fb55 added a commit to inikulin/parse5 that referenced this pull request Mar 13, 2022
@fb55
feat(parser): Align foreign content with spec
b4ae455 
The behaviour for parsing foreign content was updated in whatwg/html#6455 and whatwg/html#6736. This catches us up to the current specced behaviour.
@fb55 fb55 mentioned this pull request Mar 13, 2022
Merged
syjer added a commit to digitalfondue/jfiveparse that referenced this pull request Mar 13, 2022
@syjer
update to spec whatwg/html#6736
e8bdab2
syjer added a commit to digitalfondue/jfiveparse that referenced this pull request Mar 13, 2022
@syjer
Update parser to latest spec (#33)
1cdda0e 
* initial work for updating parser to latest test: fix search
* update to spec whatwg/html#6736
* fix .dat parsing logic
* test against lts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
compat Standard is not web compatible or proprietary feature needs standardizing interop Implementations are not interoperable with each other normative change topic: parser
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unmatched </p> or </br> inside foreign context needs a special parser rule
3 participants
@zcorpan @mfreed7 @domenic