Skip to content

Commit

Permalink
Remove web platform tests from this repo
Browse files Browse the repository at this point in the history
They are now maintained in the web-platform-tests repository proper. Closes #440; closes #411.
  • Loading branch information
domenic committed Apr 26, 2016
1 parent 39fe868 commit 9eef665
Show file tree
Hide file tree
Showing 35 changed files with 25 additions and 4,644 deletions.
1 change: 1 addition & 0 deletions reference-implementation/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ node_modules/
npm-debug.log

bench/results/
web-platform-tests/

browser-tests/bundle.js
18 changes: 14 additions & 4 deletions reference-implementation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,20 @@ The original tests are also written in ES6, using the [tape](https://github.com/

### Web Platform Tests

After we started implementing this in browsers, we realized that we should probably have written the tests in standard [web platform tests](https://github.com/w3c/web-platform-tests) format.
After we started implementing this in browsers, we realized that we should probably have written the tests in standard [web platform tests](https://github.com/w3c/web-platform-tests) format. Fixing this has been an ongoing effort, with major help from WebKit contributors, who ported the initial set of tests from our original format.

Actually, WebKit noticed this first, and [converted all the tests](https://github.com/Igalia/streams/tree/webkit-tests/reference-implementation/webkit/reference-implementation). So we're starting to take their work and port it back into this repo. While we do so, we're splitting things up a bit so it's easier for implementers to work on only certain sections of the spec at a time, e.g. readable streams first.
The web platform tests for streams are found in the [streams directory](https://github.com/w3c/web-platform-tests/tree/master/streams) of the web platform tests repository, and maintained via pull requests to that repository.

Anyway, one thing to keep an eye out for is that due to this porting work, the coding style and level of ES6 feature usage is going to vary a decent bit.
For local development while working on the spec, you can run

To run the web platform tests against the reference implementation from within Node.js, type `npm run wpt` in this folder.
```
bash ./update-web-platform-tests.sh
```

to clone the web platform tests repository locally, and then use

```
npm run wpt
```

to run the streams web platform tests against the reference implementation, inside a Node.js emulated-DOM environment. If you make changes to the tests locally, for example while making a spec change, please send them as a pull request to the web platform tests repository.
2 changes: 1 addition & 1 deletion reference-implementation/run-web-platform-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import WritableStream from "./lib/writable-stream";
import ByteLengthQueuingStrategy from "./lib/byte-length-queuing-strategy";
import CountQueuingStrategy from "./lib/count-queuing-strategy";

const testsPath = path.resolve(__dirname, "web-platform-tests");
const testsPath = path.resolve(__dirname, "web-platform-tests/streams");

wptRunner(testsPath, setup)
.then(failures => process.exit(failures))
Expand Down
9 changes: 9 additions & 0 deletions reference-implementation/update-web-platform-tests.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/bin/bash
set -e

if [ -d "web-platform-tests" ]; then
cd web-platform-tests
git pull origin master
else
git clone --depth 1 https://github.com/w3c/web-platform-tests.git
fi
292 changes: 0 additions & 292 deletions reference-implementation/web-platform-tests/.eslintrc

This file was deleted.

This file was deleted.

0 comments on commit 9eef665

Please sign in to comment.