Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship between streams tests in whatwg/streams repo and W3C/web-platform-tests repo #440

Closed
youennf opened this issue Apr 20, 2016 · 5 comments

Comments

@youennf
Copy link
Contributor

youennf commented Apr 20, 2016

I have a change to upstream to one of the streams test.
Should I upstream it here or in W3C repo?
How is made the sync between the two repos?

@domenic
Copy link
Member

domenic commented Apr 20, 2016

Oh! I had no idea that the tests had been ported to WPT! That's very exciting!

It looks like the WPT tests don't have the very latest changes from e601d69. (There were only a small number of test changes, because most of the changes there were to the internal implementation. But there were a few.)

So, I think you should upstream to here, but after you do that, I will sync the changes in this repo to WPT, and then delete them from this repo and add a pointer link.

@youennf
Copy link
Contributor Author

youennf commented Apr 21, 2016

Related PR is #441

@domenic
Copy link
Member

domenic commented Apr 21, 2016

@yurydelendik I see you did the original upstreaming of the streams tests to the WPT repo. Can you comment on why you changed all the filenames to be ".https.html" instead of ".html"?

@wanderview
Copy link
Member

@domenic I believe the tests run the streams in service workers. We require https for service workers. The .https.html naming suffix tells the test harness to launch the test in an https origin.

@domenic
Copy link
Member

domenic commented Apr 21, 2016

Hmm OK, that makes sense.

domenic added a commit that referenced this issue Apr 26, 2016
They are now maintained in the web-platform-tests repository proper. Closes #440; closes #411.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants