-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explainer for proposed stream changes related to VideoFrame processing #1193
Conversation
@MattiasBuelens, this is a first draft of the explainer, could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for kicking this off! Looks pretty good already. 👍
Co-authored-by: Mattias Buelens <649348+MattiasBuelens@users.noreply.github.com>
Co-authored-by: Mattias Buelens <649348+MattiasBuelens@users.noreply.github.com>
Co-authored-by: Mattias Buelens <649348+MattiasBuelens@users.noreply.github.com>
Mention TransformStream readableType/writableType. Add more future work/open questions.
@alvestrand, @aboba, @jan-ivar, @ricea, PTAL. |
@domenic, could you also take a look whether that makes sense to you and whether that is worth including in streams (instead of special casing VideoFrame handling). |
Generally looks good to me, and makes sense as a concept. Lots of details to work out, but I'm happy for that to be done in future revisions or in a spec PR, instead of having a perfect explainer ahead of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks great! Just a question on mentioning WebIDL, and nits. I also think we should show workers in the example, since that's what we've spec'ed (see suggestion).
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Build error seems unrelated to this PR: |
Correct, #1198 should fix the spec build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Discussed at WebRTC editor's meeting today, and was thought as good to go as a first version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. @MattiasBuelens has a changes-requested review which we need to make sure it satisfied though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Co-authored-by: Mattias Buelens <649348+MattiasBuelens@users.noreply.github.com>
As discussed at last WebRTC/WHATWG Streams meeting, we are converging on a potential solution for VideoFrame handling in streams. This explainer is the first step towards a more formal solution.