Fixing 'ReadableStream: should call pull when trying to read from a started, empty stream' flakiness #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tarted, empty stream' flakiness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some slow WebKit bots have difficulties with this test.
The delay(1) callback is sometimes called before the callback to the first pull request promise, which makes the call to the first read() call waiting for the first pull request promise to finish.
Increasing the delay from 1 to 10 before actually reading the data is solving the issue on WebKit bots.
As a side note, 10 ms is usually considered as too small for slow WebKit bots.
This patch tries to make the test more deterministic.