Prohibit setting a strategy size for byte streams #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readable byte streams always measure chunks in bytes, so specifying a size() function in the strategy never did anything. This is confusing, so throw an exception when size() is specified along with type: 'bytes'. Update editorial descriptions to match the new behaviour. Fixes whatwg#792.
|
@domenic The algorithmic changes are trivial, but the editorial parts are quite tricky. |
domenic
approved these changes
Nov 16, 2017
| <code>size()</code> method. <!-- TODO: https://github.com/whatwg/streams/issues/427 --> | ||
| Concretely, a queuing strategy is given by any JavaScript object with a <code>highWaterMark</code> property. For byte | ||
| streams the <code>highWaterMark</code> always has units of bytes. For other streams the default unit is <a>chunks</a>, | ||
| but a <code>size()</code> function can be included in the strategy object which returns the size for a given chunk. This |
There was a problem hiding this comment.
Good correction, from method to function.
There was a problem hiding this comment.
This wasn't actually intentional: I delete the text and rewrote it :-)
hubot
pushed a commit
to WebKit/WebKit-http
that referenced
this pull request
Dec 12, 2017
…eating a readable byte stream https://bugs.webkit.org/show_bug.cgi?id=180470 Reviewed by Youenn Fablet. LayoutTests/imported/w3c: One new test imported from WPT to check that RangeError is thrown if a size is provided. * web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated expectations. * web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Updated expectations. * web-platform-tests/streams/readable-byte-streams/general.js: Imported one test case from WPT. * web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt: Updated expectations. Source/WebCore: Throw a RangeError if a ReadableStream is created with type 'bytes' and with a non-undefined strategy size, as per latest spec: - whatwg/streams#856 - https://streams.spec.whatwg.org/#rs-constructor (step 4.c) One new test imported from WPT to check that RangeError is thrown. * Modules/streams/ReadableStream.js: (initializeReadableStream): Check strategy size and throw RangeError if needed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@225784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readable byte streams always measure chunks in bytes, so specifying a size()
function in the strategy never did anything. This is confusing, so throw an
exception when size() is specified along with type: 'bytes'.
Update editorial descriptions to match the new behaviour.
Tests are in web-platform-tests/wpt#8279.
Fixes #729.
Preview | Diff