ShouldCallPull: Assert desiredSize is not null #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReadableStreamDefaultControllerShouldCallPull implicitly assumes that desiredSize is not null when it compares it to 0. This is guaranteed by the check of ReadableStreamDefaultControllerCanCloseOrEnqueue(controller), but it's not obvious. Add an assert to make it explicit. Also do the same for ReadableByteStreamControllerShouldCallPull. No functional changes.
|
@domenic What do you think? |
domenic
approved these changes
May 22, 2018
index.bs
Outdated
| @@ -1826,6 +1826,7 @@ nothrow>ReadableStreamDefaultControllerShouldCallPull ( <var>controller</var> )< | |||
| 1. If ! IsReadableStreamLocked(_stream_) is *true* and ! ReadableStreamGetNumReadRequests(_stream_) > *0*, return | |||
| *true*. | |||
| 1. Let _desiredSize_ be ReadableStreamDefaultControllerGetDesiredSize(_controller_). | |||
ReadableStreamDefaultControllerShouldCallPull was missing an exclamation mark before ReadableStreamDefaultControllerGetDesiredSize. Fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadableStreamDefaultControllerShouldCallPull implicitly assumes that
desiredSize is not null when it compares it to 0. This is guaranteed by
the check of
ReadableStreamDefaultControllerCanCloseOrEnqueue(controller), but it's
not obvious. Add an assert to make it explicit.
Also do the same for ReadableByteStreamControllerShouldCallPull.
No functional changes.
Closes #919.
Preview | Diff