Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShouldCallPull: Assert desiredSize is not null #926

Merged
merged 2 commits into from
May 23, 2018

Commits on May 18, 2018

  1. ShouldCallPull: Assert desiredSize is not null

    ReadableStreamDefaultControllerShouldCallPull implicitly assumes that
    desiredSize is not null when it compares it to 0. This is guaranteed by
    the check of
    ReadableStreamDefaultControllerCanCloseOrEnqueue(controller), but it's
    not obvious. Add an assert to make it explicit.
    
    Also do the same for ReadableByteStreamControllerShouldCallPull.
    
    No functional changes.
    ricea committed May 18, 2018
    Configuration menu
    Copy the full SHA
    a5a30d5 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2018

  1. Add missing exclamation mark

    ReadableStreamDefaultControllerShouldCallPull was missing an exclamation mark
    before ReadableStreamDefaultControllerGetDesiredSize. Fix it.
    ricea committed May 23, 2018
    Configuration menu
    Copy the full SHA
    edcef0a View commit details
    Browse the repository at this point in the history