Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"the substring from pointer in input" #349

Closed
GPHemsley opened this issue Oct 29, 2017 · 4 comments
Closed

"the substring from pointer in input" #349

GPHemsley opened this issue Oct 29, 2017 · 4 comments
Labels
clarification Standard could be clearer

Comments

@GPHemsley
Copy link
Member

#343 introduced the phrasing "the substring from pointer in input" to essentially check c and the first one or two characters in remaining.

I sort of raised this in a comment at the time, but I'm actually attempting to implement it now, and it's a little tedious, so I wanted to revisit: Is there a better way to phrase this, perhaps in a way that makes better use of the definitions in §1.2. Parsers?

@GPHemsley
Copy link
Member Author

Relatedly, #343 claims to solve the remaining problem outlined in #308, but I'm not convinced that it does.

@annevk annevk added clarification Standard could be clearer and removed non-normative labels Apr 26, 2020
@annevk
Copy link
Member

annevk commented May 4, 2020

We could make it "c concatenated with remaining".

@rmisev
Copy link
Member

rmisev commented May 4, 2020

We could make it "c concatenated with remaining".

Before using remaining we need to checkc is not EOF. While "the substring from pointer in input" is just empty when c is EOF.

@annevk
Copy link
Member

annevk commented Oct 9, 2021

Since substring is now defined I think this is clear enough.

@annevk annevk closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer
Development

No branches or pull requests

4 participants