Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep blob: URLs containing file: origins as an exercise for the reader #780

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented Jul 24, 2023

Blocklisting blob: URLs containing a file: origin from getting a proper origin was a bridge too far. See #506 for a slightly less ambitious approach that could still work.

Closes #775.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

Blocklisting blob: URLs containing a file: origin from getting a proper origin was a bridge too far. See #506 for a slightly less ambitious approach that could still work.

Closes #775.
@annevk
Copy link
Member Author

annevk commented Jul 24, 2023

@CanadaHonk I suppose Gecko is supportive?

@CanadaHonk
Copy link
Member

I agree but I don't represent Gecko, not sure who to ping for this either.

@annevk
Copy link
Member Author

annevk commented Jul 25, 2023

@valenting or @ricea?

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine editorially; I haven't tracked down the history motivating this change.

@ricea
Copy link

ricea commented Jul 26, 2023

Chromium is supportive (because it moves our implementation closer to compliance).

@annevk annevk merged commit fff33c3 into main Jul 26, 2023
2 checks passed
@annevk annevk deleted the annevk/origin-file branch July 26, 2023 12:47
Ms2ger pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 18, 2023
whimboo pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 22, 2023
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 13, 2023
…ned origins, a=testonly

Automatic update from web-platform-tests
URL: file: URLs have implementation-defined origins

See whatwg/url#780 for context.

--

wpt-commits: 373be7b4252952bc90d515be07b2dbd9ff60540a
wpt-pr: 41158
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Sep 14, 2023
…ned origins, a=testonly

Automatic update from web-platform-tests
URL: file: URLs have implementation-defined origins

See whatwg/url#780 for context.

--

wpt-commits: 373be7b4252952bc90d515be07b2dbd9ff60540a
wpt-pr: 41158
Lightning00Blade pushed a commit to Lightning00Blade/wpt that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants