Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file as allowed scheme for blob origin #775

Closed
wants to merge 1 commit into from

Conversation

CanadaHonk
Copy link
Member

@CanadaHonk CanadaHonk commented May 30, 2023

This is a minor tweak to #771 to also include file as an allowed scheme for blob URL origins. Not sure if WPT changes are needed?


Preview | Diff

@CanadaHonk
Copy link
Member Author

CC @annevk @rmisev

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a blob:file test that needs updating. Removing the origin field might be best for now. @domenic?

<li><p>If <var>pathURL</var>'s <a for=url>scheme</a> is not "<code>http</code>" and not
"<code>https</code>", then return a new <a>opaque origin</a>.
<li><p>If <var>pathURL</var>'s <a for=url>scheme</a> is not "<code>http</code>", "<code>https</code>",
and "<code>file</code>" then return a new <a>opaque origin</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or

(and make sure lines don't exceed 100 columns)

@annevk
Copy link
Member

annevk commented May 31, 2023

Also, you can't sign whatwg/participant-data@eaf5377 with a pseudonym.

annevk added a commit that referenced this pull request Jul 24, 2023
Blocklisting blob: URLs containing a file: origin from getting a proper origin was a bridge too far. See #506 for a slightly less ambitious approach that could still work.

Closes #775.
@annevk annevk closed this in #780 Jul 26, 2023
annevk added a commit that referenced this pull request Jul 26, 2023
Blocklisting blob: URLs containing a file: origin from getting a proper origin was a bridge too far. See #506 for a slightly less ambitious approach that could still work.

Closes #775.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants