Remove a check for array index in [[Set]] #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array index properties are not special on objects with named setters. Note that the corresponding step in [[DefineOwnProperty]] does not have this condition. This change does not affect normal usage; it is only detectable by messing with the prototype of the object. Gecko and WebKit already handle array indexes the same way as other properties; Chrome does for DOMStringMap but does not for Storage. (In the Storage case, it does the exact opposite of the current specification.)
domenic
approved these changes
Apr 4, 2019
Ms2ger
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 4, 2019
|
Here's the test for Storage: web-platform-tests/wpt#16262 Still need one from DOMStringMap. |
|
DOMStringMap: web-platform-tests/wpt#16278 |
Ms2ger
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 15, 2019
The specification was updated in whatwg/webidl#706.
Ms2ger
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 15, 2019
Ms2ger
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 15, 2019
The specification was updated in whatwg/webidl#706.
Ms2ger
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 15, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 5, 2019
…, a=testonly Automatic update from web-platform-tests Add some binding tests for DOMStringMap. The specification was updated in whatwg/webidl#706. -- wpt-commits: 78193fbe36156498378dcd00ee6f1e28007ed355 wpt-pr: 16278
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 5, 2019
…only Automatic update from web-platform-tests Improve tested values in set.window.js. -- Make set.window.js more robust in its cleanup. -- Update test for Storage [[Set]]. See whatwg/webidl#706. -- wpt-commits: 0f60b8c9515eee43dd72679361129fffaa56b26f, 4b0d772a1cf073b5ce47552249be5134e40c19f1, e5c1ea19c0563ea97e26ad81ba07ce89f840c47d wpt-pr: 16262
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Jun 6, 2019
…, a=testonly Automatic update from web-platform-tests Add some binding tests for DOMStringMap. The specification was updated in whatwg/webidl#706. -- wpt-commits: 78193fbe36156498378dcd00ee6f1e28007ed355 wpt-pr: 16278
mykmelez
pushed a commit
to mykmelez/gecko
that referenced
this pull request
Jun 6, 2019
…only Automatic update from web-platform-tests Improve tested values in set.window.js. -- Make set.window.js more robust in its cleanup. -- Update test for Storage [[Set]]. See whatwg/webidl#706. -- wpt-commits: 0f60b8c9515eee43dd72679361129fffaa56b26f, 4b0d772a1cf073b5ce47552249be5134e40c19f1, e5c1ea19c0563ea97e26ad81ba07ce89f840c47d wpt-pr: 16262
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
The specification was updated in whatwg/webidl#706.
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 23, 2019
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…, a=testonly Automatic update from web-platform-tests Add some binding tests for DOMStringMap. The specification was updated in whatwg/webidl#706. -- wpt-commits: 78193fbe36156498378dcd00ee6f1e28007ed355 wpt-pr: 16278 UltraBlame original commit: fd0d5d305b28fa2bb42346f07a37d9ca74db1533
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…only Automatic update from web-platform-tests Improve tested values in set.window.js. -- Make set.window.js more robust in its cleanup. -- Update test for Storage [[Set]]. See whatwg/webidl#706. -- wpt-commits: 0f60b8c9515eee43dd72679361129fffaa56b26f, 4b0d772a1cf073b5ce47552249be5134e40c19f1, e5c1ea19c0563ea97e26ad81ba07ce89f840c47d wpt-pr: 16262 UltraBlame original commit: 6837f59004432d0b31c8904721d598434a4a87f4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…, a=testonly Automatic update from web-platform-tests Add some binding tests for DOMStringMap. The specification was updated in whatwg/webidl#706. -- wpt-commits: 78193fbe36156498378dcd00ee6f1e28007ed355 wpt-pr: 16278 UltraBlame original commit: fd0d5d305b28fa2bb42346f07a37d9ca74db1533
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…only Automatic update from web-platform-tests Improve tested values in set.window.js. -- Make set.window.js more robust in its cleanup. -- Update test for Storage [[Set]]. See whatwg/webidl#706. -- wpt-commits: 0f60b8c9515eee43dd72679361129fffaa56b26f, 4b0d772a1cf073b5ce47552249be5134e40c19f1, e5c1ea19c0563ea97e26ad81ba07ce89f840c47d wpt-pr: 16262 UltraBlame original commit: 6837f59004432d0b31c8904721d598434a4a87f4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…, a=testonly Automatic update from web-platform-tests Add some binding tests for DOMStringMap. The specification was updated in whatwg/webidl#706. -- wpt-commits: 78193fbe36156498378dcd00ee6f1e28007ed355 wpt-pr: 16278 UltraBlame original commit: fd0d5d305b28fa2bb42346f07a37d9ca74db1533
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…only Automatic update from web-platform-tests Improve tested values in set.window.js. -- Make set.window.js more robust in its cleanup. -- Update test for Storage [[Set]]. See whatwg/webidl#706. -- wpt-commits: 0f60b8c9515eee43dd72679361129fffaa56b26f, 4b0d772a1cf073b5ce47552249be5134e40c19f1, e5c1ea19c0563ea97e26ad81ba07ce89f840c47d wpt-pr: 16262 UltraBlame original commit: 6837f59004432d0b31c8904721d598434a4a87f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array index properties are not special on objects with named setters. Note
that the corresponding step in [[DefineOwnProperty]] does not have this
condition.
This change does not affect normal usage; it is only detectable by messing with
the prototype of the object.
Gecko and WebKit already handle array indexes the same way as other properties;
Chrome does for DOMStringMap but does not for Storage. (In the Storage case, it
does the exact opposite of the current specification.)
Preview | Diff