Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't locate the referenced part from a note #213

Closed
ryoqun opened this issue Jun 14, 2018 · 1 comment
Closed

Can't locate the referenced part from a note #213

ryoqun opened this issue Jun 14, 2018 · 1 comment
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@ryoqun
Copy link
Contributor

ryoqun commented Jun 14, 2018

Hi, just a minor suggestion.

https://xhr.spec.whatwg.org/commit-snapshots/9f22aa3b0db7a97b5c28e5f5d244b49b2958714f/#the-setrequestheader()-method

at the end of the send() method section.

Maybe this got outdated by the introduction of the Fetch API?
@annevk
Copy link
Member

annevk commented Jun 14, 2018

Thanks! Not the API, but the Fetch Standard, yes. Would you be willing to submit a PR to remove that note? It doesn't seem worth keeping around to me.

@annevk annevk added good first issue Ideal for someone new to a WHATWG standard or software project clarification Standard could be clearer labels Jun 14, 2018
@ryoqun ryoqun mentioned this issue Jun 15, 2018
Merged
@annevk annevk closed this as completed in ce716e8 Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Standard could be clearer good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryoqun @annevk