Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo (no timeout after load) #217

Closed
Mouvedia opened this issue Jul 28, 2018 · 8 comments
Closed

typo (no timeout after load) #217

Mouvedia opened this issue Jul 28, 2018 · 8 comments
Labels
clarification Standard could be clearer

Comments

@Mouvedia
Copy link

<TimothyGu> Could you file an issue?

972797f#r29848015

@annevk
Copy link
Member

annevk commented Aug 7, 2018

I think completed is fine here, since we don't know if the request will succeed or fail.

@annevk
Copy link
Member

annevk commented Aug 7, 2018

@TimothyGu I guess you had a different perspective on that?

@annevk annevk added the clarification Standard could be clearer label Aug 7, 2018
@Mouvedia
Copy link
Author

Mouvedia commented Aug 7, 2018

You are using the term "completed" for onloaded which means abort can fire after onload; surely that's not desired? The order matters.

cf https://xhr.spec.whatwg.org/#ref-for-concept-event-fire-progress%E2%91%A4

@annevk
Copy link
Member

annevk commented Aug 7, 2018

This table has no normative meaning, it just summarizes a bunch of details. "Completed" just means that the fetch is over with.

@TimothyGu
Copy link
Member

@annevk Nah I wasn't sure if this was an actual bug or no so I just asked @Mouvedia to file an issue.

@Mouvedia
Copy link
Author

Mouvedia commented Aug 7, 2018

@annevk it's unclear and was incorrectly implemented before: https://bugzilla.mozilla.org/show_bug.cgi?id=703380

@annevk
Copy link
Member

annevk commented Aug 7, 2018

@Mouvedia that bug doesn't cite the specification as being problematic though. And again, it's a non-normative summary that implementers shouldn't really consult anyway.

I suppose we could add a paragraph after the table: "The abort, error, load, and timeout events are mutually exclusive." Would that help?

@Mouvedia
Copy link
Author

Mouvedia commented Aug 7, 2018

I suppose we could add a paragraph after the table: "The abort, error, load, and timeout events are mutually exclusive." Would that help?

That would be even more confusing. Forget about it.

@Mouvedia Mouvedia closed this as completed Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer
Development

No branches or pull requests

3 participants