Incompatible with latest version of docker (since 1.12)

[giftig]

The docker daemon log shows me this:

Handler for POST /containers/40a0452be28ff824551dee06516985060009792314a2247f5169fa07e7b10f65/start returned error: starting container with HostConfig was deprecated since v1.10 and removed in v1.12

I updated to the latest version available in the central repository (0.9.0-M5) but it didn't solve the problem. This has broken my test suite and I've had to disable components depending on this library so it'd be helpful if it were made compatible with docker >= 1.12.

[viktortnk]

Hi @giftig

I update local (boot2docker) enviroment to latest on one of my machines. Unfortunately I didn't manage to find the same error you got, but had a different one.

I updated docker-java and tuned spotify executor a bit.

I can't see passing hostConfig on container start anywhere.

Could you please try to run

./sbt "scalatest/test-only com.whisk.docker.MongodbServiceSpec"

on latest master branch. And tell if it works for you

My current env.

➜  ~ docker version
Client:
 Version:      1.12.1
 API version:  1.24
 Go version:   go1.7
 Git commit:   23cf638
 Built:        Thu Aug 18 22:32:50 UTC 2016
 OS/Arch:      darwin/amd64

Server:
 Version:      1.12.1
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   23cf638
 Built:        Thu Aug 18 17:52:38 2016
 OS/Arch:      linux/amd64

Tomorrow I might check on another machine with docker4mac

[francisdb]

@giftig where do I find this daemon log? Want to check if the issues we have on MacOS are related.

[giftig]

@francisdb I'm not at the same machine I used at the moment to check, but I believe it was just /var/log/docker.log. May have been /var/log/docker/daemon.log. If it helps I was running docker natively in 64-bit linux (fedora 23). I'll double-check that path if needbe when I get home; it's my home desktop and I'm currently at work.

[francisdb]

Ah so this is not specific for MacOS then.

[giftig]

Nothing to do with mac OS, no. I did try running my tests on a mac first and discovered them broken, but didn't investigate in that environment for long and looked into it more when I got home and tried it under fedora. I can't confirm the problem was the same on my mac as on my fedora machine, but since it seems to be related to the use of a deprecated feature, I'd be inclined to think it's cross-platform.

[viktortnk]

should be fixed in 0.9.0-M6

[giftig]

Hmm my tests are still failing, but the error has changed in 0.9.0-M6 and the error I'm getting is a failure to connect to the redis server I'm having whisk start with docker. Very possibly a configuration problem my end since I originally wrote the tests for whisk version 0.6.x so I'll dig into it this evening and check nothing else is wrong.

[giftig]

Yep, I've tried it in my linux environment and my tests are working just fine now under 0.9.0-M6. Pretty sure the connection issue was because I didn't take the virtual machine into account when using docker on a mac with docker-machine.

Thanks for such a speedy fix!

[viktortnk]

cool, thanks for update