Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust JSON parsing #270

Merged
merged 5 commits into from
Apr 14, 2024
Merged

More robust JSON parsing #270

merged 5 commits into from
Apr 14, 2024

Conversation

whitead
Copy link
Collaborator

@whitead whitead commented Apr 13, 2024

  • Added more json variants observed from Claude
  • Added unit test with pytest features
  • Removed older asyncio unit testing syntax
  • Incremented version

paperqa/utils.py Outdated Show resolved Hide resolved
tests/test_paperqa.py Outdated Show resolved Hide resolved
tests/test_paperqa.py Outdated Show resolved Hide resolved
tests/test_paperqa.py Outdated Show resolved Hide resolved
whitead and others added 2 commits April 13, 2024 12:55
Co-authored-by: James Braza <jamesbraza@gmail.com>
@whitead whitead requested a review from jamesbraza April 13, 2024 20:08
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some code style related comments, otherwise LGTM

tests/test_paperqa.py Show resolved Hide resolved
tests/test_paperqa.py Outdated Show resolved Hide resolved
tests/test_paperqa.py Outdated Show resolved Hide resolved
tests/test_paperqa.py Outdated Show resolved Hide resolved
@whitead whitead merged commit c4957cb into main Apr 14, 2024
1 check failed
@whitead whitead deleted the json-parse branch April 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants