[RFC] Add current page start and end count #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function getCurrentPageOffsetEnd() | ||
| { | ||
| return (true === $this->hasNextPage()) | ||
| ? $this->getCurrentPage() * $this->getMaxPerPage() |
There was a problem hiding this comment.
this will be wrong for the last page. you will display 11 - 20 of 16 which is quite weird
There was a problem hiding this comment.
ah no, sorry, it is what $this->hasNextPage() is about
|
Tests should be added |
This PR adds the ability to display the current page start count and end count.
Example:
`<p>Showing {{ pagination.getCurrentPageOffsetStart }} - {{ pagination.getCurrentPageOffsetEnd }} of {{ pagination.getNbResults }} results</p>`
ping @stof |
|
Should be documented. Was hard to find. |
leevigraham
added a commit
to leevigraham/Pagerfanta
that referenced
this pull request
Jul 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to calculate the current page start and end count.
Example (in twig):
<p>Showing {{ pagination.getCurrentPageOffsetStart }} - {{ pagination.getCurrentPageOffsetEnd }} of {{ pagination.getNbResults }} results</p>