[RFC] Added data-pagination to view output.

[leevigraham]

The data attribute is a json_encoded array of the following:

• url
• totalResults
• totalPages
• currentPage
• currentPageOffsetStart
• currentPageOffsetEnd

Builds on top off PR #91

Is this something that interests anyone?

This update makes it easier to add other JS hooks / events. I'm currently using it to build a perPage select box:

The method in my widget looks like:

        _processPerPage: function (event) {

            event.preventDefault();

            var paginationData = this.element.find(this.options.paginationSelector).data('pagination'),
                currentOffset = paginationData.currentPageOffsetStart,
                perPage = $(event.target).val(),
                newPage = Math.ceil(currentOffset / perPage),
                uri = new URI(paginationData.url);

            uri.setSearch(this.options.pageKey, newPage);
            uri.setSearch(this.options.perPageKey, perPage);

            $.ajax({
                type: 'get',
                url: uri.href(),
                beforeSend: $.proxy(this._beforeSend, this),
                success: $.proxy(this._success, this),
                complete: $.proxy(this._complete, this)
            });

        },

[pablodip]

This should be optional, thus the views work the same as before by default. Also tests should be passing (some of the views are not passing now), and you should add tests for this as well.

[pablodip]

You can access to the route generator in the view directly.

[leevigraham]

Hmm. How? I can see it anywhere?

[pablodip]

https://github.com/whiteoctober/Pagerfanta/blob/master/src/Pagerfanta/View/DefaultView.php#L47

The route generator is injected from the view the the template:
https://github.com/whiteoctober/Pagerfanta/blob/master/src/Pagerfanta/View/DefaultView.php#L79

[leevigraham]

I'm probably daft but I don't understand. Are you suggesting that the router should be saved as a class variable in the DefaultView class?

[pablodip]

Yes, using somehow the routegenerator that is already in the view.

[pablodip]

Do you plan to finish this?

[leevigraham]

I do. I was justa bit confused.

To clarify you're suggesting:

When the RouteGenerator is passed into configureTemplate() set a class variable on DefaultView?

[pablodip]

Or just in the render method, as configurateTemplate what does is configurating the template)

[pablodip]

Why removing the option?

[pablodip]

Could you rebase and add documentation for this please?

[pablodip]

Do you plan to do this?

[pablodip]

Are you alive? :)