-
Notifications
You must be signed in to change notification settings - Fork 110
Conversation
stof
commented
Aug 19, 2015
- test against more PHP versions, including PHP 7 and HHVM
- remove testing against Symfony 2.2 as it is not supported by the bundle anymore
- add testing against newer versions of symfony than 2.3
- switch to the faster container-based infrastructure on Travis
- persist the composer cache between builds
This isn't working on Travis: #121 PS: Do you know why pull requests on Github are not linked to Travis? |
@pablodip the builds are working on Travis, but the status is not set. This is generally caused by the fact that they don't have an OAuth token for someone with write access to the repo, to authenticate for the commit status API. |
- test against more PHP versions, including PHP 7 and HHVM - remove testing against Symfony 2.2 as it is not supported by the bundle anymore - add testing against newer versions of symfony than 2.3 - switch to the faster container-based infrastructure on Travis - persist the composer cache between builds
and I updated the PR to fix the syntax error in the Yaml file |
I've just given permissions to Travis. Thanks for the info! Tests are only passing with php 5.6 and symfony 2.3. Is that expected? https://travis-ci.org/whiteoctober/WhiteOctoberPagerfantaBundle/builds/78013250 |
Well, your bundle was not tested with recent Symfony versions before, and it looks like your test project has an issue with them |
I know what it is: your controller is trying to change the locale, but it does it too late and changing the locale in the Request has no effect on the translator anymore as it is already initialized (in 2.3, the translator locale was initialized only on the first usage of the translator). I will fix it |
@pablodip looks like they still don't have the necessary permission. Maybe your organization uses third-party access control and blocks Travis, so that your token does not allow them to make the API call |
Improve the travis configuration
I've just sent an authorisation request to @whiteoctober. @richsage could you possibly have a look? Thanks a lot @stof! |
@pablodip just seen it - need to confirm internally (because it gives Travis access to all private repos within the organisation) but will let you know ASAP :) |
@richsage The scopes used by travis-ci.org only give them basic info about the repos, but it does not get access to the content of the repo. Only travis-ci.com is getting full access to private repos, but this is a separate application. |
I've now approved the access request for Travis. Sorry it took so long! And thanks @stof for the detailed explaination. |