Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

Improve the travis configuration #121

Merged
merged 2 commits into from
Sep 1, 2015
Merged

Improve the travis configuration #121

merged 2 commits into from
Sep 1, 2015

Conversation

stof
Copy link
Contributor

@stof stof commented Aug 19, 2015

  • test against more PHP versions, including PHP 7 and HHVM
  • remove testing against Symfony 2.2 as it is not supported by the bundle anymore
  • add testing against newer versions of symfony than 2.3
  • switch to the faster container-based infrastructure on Travis
  • persist the composer cache between builds

@pablodip
Copy link
Contributor

This isn't working on Travis: #121

PS: Do you know why pull requests on Github are not linked to Travis?

@stof
Copy link
Contributor Author

stof commented Aug 31, 2015

@pablodip the builds are working on Travis, but the status is not set. This is generally caused by the fact that they don't have an OAuth token for someone with write access to the repo, to authenticate for the commit status API.
this is likely related to the permission changes they had to do in June: http://blog.travis-ci.com/2015-06-18-reauthorization-required-due-to-github-api-changes/ You need to go to Travis and authenticate again so that they renew your token.

- test against more PHP versions, including PHP 7 and HHVM
- remove testing against Symfony 2.2 as it is not supported by the bundle anymore
- add testing against newer versions of symfony than 2.3
- switch to the faster container-based infrastructure on Travis
- persist the composer cache between builds
@stof
Copy link
Contributor Author

stof commented Aug 31, 2015

and I updated the PR to fix the syntax error in the Yaml file

@pablodip
Copy link
Contributor

I've just given permissions to Travis. Thanks for the info!

Tests are only passing with php 5.6 and symfony 2.3. Is that expected? https://travis-ci.org/whiteoctober/WhiteOctoberPagerfantaBundle/builds/78013250

@stof
Copy link
Contributor Author

stof commented Aug 31, 2015

Well, your bundle was not tested with recent Symfony versions before, and it looks like your test project has an issue with them

@stof
Copy link
Contributor Author

stof commented Aug 31, 2015

I know what it is: your controller is trying to change the locale, but it does it too late and changing the locale in the Request has no effect on the translator anymore as it is already initialized (in 2.3, the translator locale was initialized only on the first usage of the translator). I will fix it

@stof
Copy link
Contributor Author

stof commented Aug 31, 2015

@pablodip looks like they still don't have the necessary permission. Maybe your organization uses third-party access control and blocks Travis, so that your token does not allow them to make the API call

pablodip added a commit that referenced this pull request Sep 1, 2015
Improve the travis configuration
@pablodip pablodip merged commit f329d7b into sampart:master Sep 1, 2015
@pablodip
Copy link
Contributor

pablodip commented Sep 1, 2015

I've just sent an authorisation request to @whiteoctober. @richsage could you possibly have a look?

Thanks a lot @stof!

@richsage
Copy link
Contributor

richsage commented Sep 1, 2015

@pablodip just seen it - need to confirm internally (because it gives Travis access to all private repos within the organisation) but will let you know ASAP :)

@stof stof deleted the patch-3 branch September 1, 2015 17:03
@stof
Copy link
Contributor Author

stof commented Sep 1, 2015

@richsage The scopes used by travis-ci.org only give them basic info about the repos, but it does not get access to the content of the repo. Only travis-ci.com is getting full access to private repos, but this is a separate application.
See http://docs.travis-ci.com/user/github-oauth-scopes/

@sampart
Copy link
Owner

sampart commented Jan 25, 2016

I've now approved the access request for Travis. Sorry it took so long! And thanks @stof for the detailed explaination.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants