Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues for wslu part #2

Closed
patrick330602 opened this issue Aug 15, 2018 · 1 comment
Closed

Some issues for wslu part #2

patrick330602 opened this issue Aug 15, 2018 · 1 comment

Comments

@patrick330602
Copy link

patrick330602 commented Aug 15, 2018

Hi, I am the author for wslu, and thank you for including my project!

But there is some small issues I found:

This line seems to be a typo: https://github.com/sirredbeard/WLinux/blob/13daf321fde605ab09098ff172a9f67a4bdea1b6/create-targz.sh#L25

Also, I find that the installation script is wrong, you should use the following instead:

sudo apt install lsb-release apt-transport-https
wget -O - https://api.patrickwu.ml/public.key | sudo apt-key add -
echo "deb https://apt.patrickwu.ml/ `lsb_release -c -s` main" | sudo tee -a /etc/apt/sources.list 
sudo apt update
sudo apt install wslu
@patrick330602 patrick330602 changed the title There is a typo Some issues for wslu part Aug 15, 2018
@sirredbeard
Copy link

I fixed the wslu install script. The use of >> instead of tee was a hold over from when I was trying to include wslu in the original image, which as I mentioned in the other issue caused headaches.

I also had fixed the other typos, pushed those edits.

I would like to revisit including wslu by default in the future, the key handling was wonky in the chroot image build environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants