Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require the name of a cache as the first argument at startup #42

Closed
whitfin opened this issue Jun 17, 2016 · 0 comments · Fixed by #44
Closed

Require the name of a cache as the first argument at startup #42

whitfin opened this issue Jun 17, 2016 · 0 comments · Fixed by #44
Assignees
@whitfin
Labels
enhancement

Comments

@whitfin
Copy link
Owner

whitfin commented Jun 17, 2016

It doesn't make sense to have a required argument as an option, so we should adjust Cachex.start_link/1 to be Cachex.start_link/2. We can provide backwards compatibility so it can go in v1.2.

Example:

Cachex.start_link([ name: :test, record_stats: true ])
Cachex.start_link(:test, [ record_stats: true ])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whitfin whitfin

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify startup to require a name as first argument whitfin/cachex
1 participant
@whitfin