Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments with leading * cannot be joined using J #305

Closed
bn-peters opened this issue Sep 15, 2022 · 1 comment
Closed

Comments with leading * cannot be joined using J #305

bn-peters opened this issue Sep 15, 2022 · 1 comment
Labels
bug

Comments

@bn-peters
Copy link
Contributor

bn-peters commented Sep 15, 2022 •
edited
Loading

Joining comments with leading * deletes the line involved. To reproduce, install Coqtail (with default configuration) and create the following file:

(* test [CURSOR] 
* test *)

Pressing J to join the lines leads to

(* test

This does not happen if the second line does not start with *.
@whonore
Copy link
Owner

whonore commented Sep 15, 2022

Thanks for reporting. After a little bit of experimentation, I've narrowed this down to something related to the j flag in 'formatoptions'. I'll have to keep looking to find the exact problem, but I'm guessing it's something to do with 'comments'.

@whonore whonore added the bug label Sep 15, 2022
@bn-peters bn-peters mentioned this issue Sep 16, 2022
Closed
whonore added a commit that referenced this issue Sep 16, 2022
@whonore
Remove 'n' flag from ending part of comments
5005b1a 
Fixes #305, #306
I'm not 100% sure why this works, or whether the flag is actually doing
anything useful in the comment opener, but I'll leave it for now.
whonore added a commit that referenced this issue Sep 16, 2022
@whonore
Remove 'n' flag from ending part of comments
c9afceb 
Fixes #305, #306
I'm not 100% sure why this works, or whether the flag is actually doing
anything useful in the comment opener, but I'll leave it for now.
Rixxc pushed a commit to Rixxc/Coqtail that referenced this issue Jul 2, 2024
@whonore @Rixxc
Remove 'n' flag from ending part of comments (whonore#307)
781359c 
Fixes whonore#305, whonore#306

I'm not 100% sure why this works, or whether the flag is actually doing anything useful in the comment opener, but I'll leave it for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whonore @bn-peters