Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the comparison methods #15

Closed
Shi-Qi-Li opened this issue Apr 17, 2024 · 2 comments
Closed

Question about the comparison methods #15

Shi-Qi-Li opened this issue Apr 17, 2024 · 2 comments

Comments

@Shi-Qi-Li
Copy link
Contributor

Hi @HpWang-whu ,
Thanks for your great work. I have some confusion while reproducing some results from the paper.

  1. In the experiment part, the comparison methods include some rotation averaging methods (e.g. HARA). I wonder how to calculate absolute t for these methods. Does it use the same least squares translation synchronization as the SGHR? If YES, how to determine the weight w for these rotation averaging methods?
  2. For these optimization-based methods, whether the hyperparameters use the original default values or other adjusted values? For example, the RR results of EIGSE3 reported in the paper are 23.2%/60.4% (full/sparse graph with YOHO+3DMatch). However, my reproduced results using the below default EIGSE3 hyperparameters are only 15%/52%.
use_mex=0;               % use_mex = false -> do not use mex function to compute weights
use_sparse=1;            % use_sparse = true -> use sparse Matlab solvers (eigs/svds)
nmax_eig_irls=50;        % nmax = maximum number of iterations of IRLS
thresh_eig_irls=1e-5;    % thresh = thrsehold on relative error to check convergence of IRLS
method="top";            % method = 'top' -> compute top eigenvectors

Any help is appreciated!

@HpWang-whu
Copy link
Collaborator

Hi @Shi-Qi-Li ,
Thanks for your interest!

  1. For HARA, we simply replace the final rotation synchronization (using L1/2 reweighting function) with SE(3) transformation synchronization.
  2. I certainly made some modifications to the hyperparameters and code of the baselines to achieve their best performances by trial and error. But I am quite sorry that I forgot my final detailed settings of them. :(

Yours,

@Shi-Qi-Li
Copy link
Contributor Author

Hi @Shi-Qi-Li , Thanks for your interest!

1. For HARA, we simply replace the final rotation synchronization (using L1/2 reweighting function) with SE(3) transformation synchronization.

2. I certainly made some modifications to the hyperparameters and code of the baselines to achieve their best performances by trial and error. But I am quite sorry that I forgot my final detailed settings of them. :(

Yours,

Thank your very much for the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants