Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ghe_domain to Environment value #78

Closed
whywaita opened this issue Jul 23, 2021 · 2 comments · Fixed by #159
Closed

Move ghe_domain to Environment value #78

whywaita opened this issue Jul 23, 2021 · 2 comments · Fixed by #159
Labels
good first issue Good for newcomers

Comments

@whywaita
Copy link
Owner

#61 changed the method of authentication.
one myshoes uses one GitHub Apps.

So, myshoes host only one ghe_domain.
targets table does not need to has a ghe_domain column.
@whywaita whywaita changed the title move ghe_domain to Environment value Move ghe_domain to Environment value Jul 23, 2021
@whywaita whywaita added the good first issue Good for newcomers label Aug 17, 2021
@Damola12345
Copy link

hi @whywaita how can i help with this task ?

@whywaita
Copy link
Owner Author

whywaita commented Jun 6, 2022

hi @Damola12345!

I added How to contribute in README. #144
Please check it.

@whywaita whywaita mentioned this issue Dec 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ghe_domain from target whywaita/myshoes
2 participants
@whywaita @Damola12345