Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation: make sure that fvo ids are globally unique #37

Closed
dasch124 opened this issue Jan 11, 2024 · 2 comments
Closed

validation: make sure that fvo ids are globally unique #37

dasch124 opened this issue Jan 11, 2024 · 2 comments

Comments

@dasch124
Copy link
Contributor

Theoretically, all fvo elements should have a globally unique xml:id by prefixing them with the document ids. Since this is beyond the current document-internal validation we've implemented so far, we need to add this.

Currently there are some fvo ids where the "document id" part of the fvo id reads "tf_template". https://github.com/search?q=repo%3Awibarab%2Ffeaturedb+xml%3Aid%3D%22ft_template&type=code

@dasch124
Copy link
Contributor Author

dasch124 commented Feb 8, 2024

I think you have fixed those, right @VeronikaEngler ?

@VeronikaEngler
Copy link
Contributor

Yes, I fixed this. So unless I overlooked something somewhere all IDs should be globally unique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants