Expeculated IF/ELIF related function decompiling failure

[bloodyshade]

Hi,

I want to report an issue I've noticed recently and it seems to be related to IF/ELIF statements without ELSE.
For example:

win32com.decimal_23:695-699
       if not res:
           return 0
       elif res._sign:
           return -1
       return 1

disassembly:

430    LOAD_FAST         'res'
433    POP_JUMP_IF_TRUE  '440'
436    LOAD_CONST        ''
439    RETURN_VALUE      ''
440    LOAD_FAST         'res'
443    LOAD_ATTR         '_sign'
446    POP_JUMP_IF_FALSE '453'
449    LOAD_CONST        -1
452    RETURN_VALUE      ''
453    LOAD_CONST        1
456    RETURN_VALUE      ''
-1    RETURN_LAST       ''

Syntax error at or near `RETURN_VALUE' token at offset 456

I also had similar problems with the following files: twisted.python.reflect, twisted.internet.process and pkg_resources.
Though in twisted.internet.process it seems to be related to a try/except block inside a try block, but not really sure.

Regards,
Luis Henrique

[bloodyshade]

Hi,

Commenting the if/elif block and just leaving the "return 1" also fails to decompile, however if I comment the "return 1" or make it a "else: return 1" it decompiles fine.

EDIT: I just noticed there were a few more elifs without else in the lines before that code, commenting those as well as the if/elif block quoted and only leaving the "return 1" decompiled fine, so yes it really seems to be a problem with if/elif blocks without a matching else.

[wibiti]

I'm working on these errors, and also cleaning up some code in Scanner.py where the bugs are.

uncompyle2 isn't very good at dealing with complex if conditions that span multiple lines; it's one of these earlier in the function that is really causing the error. I have a fix for that error, and I'm working on the other files you mentioned.

[wibiti]

They should be fixed now.