Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing inert does not maintain elements previous aria-hidden state #67

Closed
straker opened this issue Sep 14, 2017 · 3 comments
Closed

Comments

@straker
Copy link
Contributor

straker commented Sep 14, 2017

If this is the element to inert

<button aria-hidden=true>Click</button>

When you inert the element and then remove the inert attribute, the aria-hidden attribute is also removed.

The aria-hidden state should probably be saved just like the tabindex so it can be properly restored.

@bkardell
Copy link
Collaborator

ouch. good catch. interested in sending a pull?

@straker
Copy link
Contributor Author

straker commented Sep 14, 2017

Can do

@alice
Copy link
Member

alice commented Sep 14, 2017

+1 good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants