Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens if requestKeyboardLock is called while 'enable keyboard lock' is true? #25

Closed
mounirlamouri opened this issue Sep 3, 2017 · 1 comment

Comments

@mounirlamouri
Copy link

Reading the spec, it seems that it does nothing. For compatibility, I would recommend being explicit about it. In general, it's better to phrase things like:

[...]
- If enable keyboard lock is true, abort these steps.
- Register a system key press handler.
- Set enable keyboard lock to true.
@jamiewalch
Copy link
Contributor

It's not a no-op; it replaces the set of reserved keys. This is covered by steps 1 and 2 of the algorithm.

@garykac garykac closed this as completed in 9c8de10 Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants