Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somewhat mangled IDL for NetworkInfomation #74

Closed
foolip opened this issue Jul 20, 2018 · 2 comments
Closed

Somewhat mangled IDL for NetworkInfomation #74

foolip opened this issue Jul 20, 2018 · 2 comments

Comments

@foolip
Copy link
Member

foolip commented Jul 20, 2018

The IDL block in https://wicg.github.io/netinfo/#-dfn-networkinformation-dfn-interface is:

[Exposed=(Window,Worker)]
interface NetworkInformation : EventTarget {
  readonly attribute ConnectionType type;
  readonly attribute EffectiveConnectionType effectiveType;
  readonly attribute Megabit downlinkMax;
  readonly attribute Megabit downlink;
  readonly attribute Millisecond rtt;
  readonly attribute boolean saveData;
  attribute EventHandler onchange;
};typedef unrestricted double Megabit;typedef unsigned long long Millisecond;

Note the lack of newlines at the end. This doesn't match the source and is probably a ReSpec bug, but I don't know so am filing a bug here first.

@igrigorik
Copy link
Member

Indeed. Perhaps a mistake in how we wired up something on this end..

@marcoscaceres any tips? :)

marcoscaceres pushed a commit that referenced this issue Nov 19, 2018
@marcoscaceres
Copy link
Contributor

sorry I didn't see this earlier... it was fixed a while ago :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants