Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should PortalActivateEvent have ports (or transferred)? #67

Closed
domenic opened this issue Apr 12, 2019 · 2 comments · Fixed by #202
Closed

Should PortalActivateEvent have ports (or transferred)? #67

domenic opened this issue Apr 12, 2019 · 2 comments · Fixed by #202
Labels
spec todo A nitty-gritty detail that needs spec work

Comments

@domenic
Copy link
Collaborator

domenic commented Apr 12, 2019

Unlike MessageEvent in, e.g, https://html.spec.whatwg.org/#window-post-message-steps, it appears that there is no special handling of any MessagePorts in the portalactivate event. Is this a conscious choice? If so, perhaps a quick note should be added explaining why.

Also note whatwg/html#4521 which may further expand the data transferred.

@jeremyroman
Copy link
Collaborator

It wouldn't be hard to add, but it kinda seems like it'd clutter things up and I'm kinda skeptical of the usefulness of it. (AFAICT it exists from a time before non-ports things could be transferred.)

A "transfer list" value like is proposed in the linked thing seems mildly more useful (albeit mostly for the "I don't know the format of this but want to pass along the same things" use case), but doesn't yet exist on MessageEvent, so we could always add it later if it proves useful there.

@domenic
Copy link
Collaborator Author

domenic commented May 8, 2020

I still think it's a good idea to add a note explaining why we're inconsistent, so I'll leave this open with a "spec todo" label.

@domenic domenic added the spec todo A nitty-gritty detail that needs spec work label May 8, 2020
domenic added a commit that referenced this issue May 20, 2020
domenic added a commit that referenced this issue May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec todo A nitty-gritty detail that needs spec work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants