Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements for OTPCredentialRequestOptions.transport are incompatible with WebIDL #37

Closed
mkruisselbrink opened this issue Mar 25, 2020 · 2 comments

Comments

@mkruisselbrink
Copy link

In https://wicg.github.io/WebOTP/#OTPCredentialRequestOptions is written "This OPTIONAL member contains a hint as to how the server might receive the OTP. The values SHOULD be members of OTPCredentialTransportType but client platforms MUST ignore unknown values.".

However WebIDL requires that converting a string to an enum throws a TypeError (https://heycam.github.io/webidl/#es-enumeration) if the string is not a valid enum member. If you do want the behavior you're describing, you should probably define transport as a sequence<DOMString> instead?

@rmondello
Copy link

Issue seems very similar to #31.

@mkruisselbrink
Copy link
Author

Ah, yes. Definitely a duplicate of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants