[Improvement] static-website/static-website - Better support for Lambda@Edge (breaking change!) #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaswittig
approved these changes
Oct 21, 2019
andreaswittig
approved these changes
Oct 28, 2019
docs/static-website.md
Outdated
| @@ -70,6 +70,7 @@ To improve the default CloudFront behavior, we developed a Lambda@Edge solution | |||
| 1. Check the **I acknowledge that this template might cause AWS CloudFormation to create IAM resources.** checkbox. | |||
| 1. Click **Create** to start the creation of the stack. | |||
| 1. Wait until the stack reaches the state **CREATE_COMPLETE** | |||
| 1. If you deployed the previous stack **not** to the us-east-1 (N. Virginia) region: TODO add docs to deploy the monitoring stack. | |||
There was a problem hiding this comment.
@michaelwittig TODO?
| EvaluationPeriods: 1 | ||
| ComparisonOperator: GreaterThanThreshold | ||
| Threshold: 0 | ||
| AlarmActions: |
There was a problem hiding this comment.
What about the OK actions?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
static-website/lambdaedge-index-documentthe output was renamed toViewerRequestLambdaEdgeFunctionVersionARNand needs to be passed tostatic-website/static-websitevia theViewerRequestLambdaEdgeFunctionVersionARNparameter.ParentAlertStack)ViewerRequestLambdaEdgeFunctionVersionARN,OriginRequestLambdaEdgeFunctionVersionARN,OriginResponseLambdaEdgeFunctionVersionARN, andViewerResponseLambdaEdgeFunctionVersionARNadded