-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: avoid 'flash' during hydration. #393
Draft
maartenbreddels
wants to merge
1
commit into
11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget
Choose a base branch
from
11-22-refactor_avoid_flash_during_hydration
base: 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maartenbreddels and the rest of your teammates on |
c9e8cc8
to
d8a8e2c
Compare
408b281
to
b022b4f
Compare
d8a8e2c
to
fe77851
Compare
b022b4f
to
c914d52
Compare
fe77851
to
5acae03
Compare
c914d52
to
85ea670
Compare
5acae03
to
c712587
Compare
85ea670
to
a3dfa44
Compare
c712587
to
9434546
Compare
a3dfa44
to
f395c0f
Compare
9434546
to
98d8802
Compare
f395c0f
to
c11e0fb
Compare
98d8802
to
9779473
Compare
c11e0fb
to
c136f22
Compare
9779473
to
53115de
Compare
c136f22
to
a00ffbd
Compare
53115de
to
af16723
Compare
a00ffbd
to
9ee5861
Compare
af16723
to
b763688
Compare
9ee5861
to
37211fa
Compare
b763688
to
06c6eb5
Compare
37211fa
to
fbd9930
Compare
06c6eb5
to
484b166
Compare
fbd9930
to
adfe553
Compare
This seems to be due to hydration and CSS animation.
484b166
to
7b07de4
Compare
adfe553
to
a092dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be due to hydration and CSS animation.