Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use vue hydration to avoid re-rendering whole page #395

Open
wants to merge 1 commit into
base: 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget
Choose a base branch
from

Conversation

maartenbreddels
Copy link
Contributor

This avoids a flash due to animations/transitions being triggered.

Copy link
Contributor Author

maartenbreddels commented Nov 22, 2023

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maartenbreddels and the rest of your teammates on Graphite Graphite

@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from c9e8cc8 to d8a8e2c Compare November 22, 2023 19:21
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from a9f28b7 to 3af977d Compare November 22, 2023 19:21
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from d8a8e2c to fe77851 Compare November 24, 2023 07:53
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from 3af977d to 0dcaaf1 Compare November 24, 2023 07:53
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from fe77851 to 5acae03 Compare November 24, 2023 07:57
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from 0dcaaf1 to 0190645 Compare November 24, 2023 07:57
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from 5acae03 to c712587 Compare November 24, 2023 13:45
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch 2 times, most recently from 91f7863 to 8f6c363 Compare November 27, 2023 20:20
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from 9434546 to 98d8802 Compare December 11, 2023 12:04
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from 8f6c363 to 0716fa4 Compare December 11, 2023 12:04
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from 98d8802 to 9779473 Compare December 11, 2023 12:41
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from 0716fa4 to c82ba01 Compare December 11, 2023 12:41
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from 9779473 to 53115de Compare December 15, 2023 12:06
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from c82ba01 to c523ba6 Compare December 15, 2023 12:06
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from 53115de to af16723 Compare December 15, 2023 12:07
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from c523ba6 to 4333884 Compare December 15, 2023 12:07
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from af16723 to b763688 Compare January 2, 2024 13:39
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from 4333884 to e1e8bf4 Compare January 2, 2024 13:39
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from b763688 to 06c6eb5 Compare January 3, 2024 17:07
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from e1e8bf4 to 640ee25 Compare January 3, 2024 17:07
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from 06c6eb5 to 484b166 Compare January 12, 2024 13:02
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from 640ee25 to 3908af4 Compare January 12, 2024 13:02
@maartenbreddels maartenbreddels marked this pull request as ready for review March 1, 2024 15:35
This avoids a flash due to animations/transitions being triggered.
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from 484b166 to 7b07de4 Compare March 10, 2024 21:24
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_use_vue_hydration_to_avoid_re-rendering_whole_page branch from 3908af4 to 2c42ed1 Compare March 10, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant