Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: directly render vue tree if root view is a ipyvue widget #392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maartenbreddels
Copy link
Contributor

Do not include a div in between temporarily. Since the widget view
is created before we try to render the the upyter-widget-mount-point
we do not need to get it asynchrounously via promises.

Copy link
Contributor Author

maartenbreddels commented Nov 22, 2023

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maartenbreddels and the rest of your teammates on Graphite Graphite

@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch 5 times, most recently from c712587 to 9434546 Compare November 27, 2023 20:22
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch 4 times, most recently from 53115de to af16723 Compare December 15, 2023 12:07
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch 2 times, most recently from b763688 to 06c6eb5 Compare January 3, 2024 17:07
@maartenbreddels maartenbreddels force-pushed the 11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget branch from 06c6eb5 to 484b166 Compare January 12, 2024 13:02
Do not include a div in between temporarily. Since the widget view
is created before we try to render the the upyter-widget-mount-point
we do not need to get it asynchrounously via promises.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant