refactor: directly render vue tree if root view is a ipyvue widget #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maartenbreddels and the rest of your teammates on |
This was referenced Nov 22, 2023
maartenbreddels
force-pushed
the
11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget
branch
5 times, most recently
from
c712587
to
9434546
Compare
maartenbreddels
force-pushed
the
11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget
branch
4 times, most recently
from
53115de
to
af16723
Compare
maartenbreddels
force-pushed
the
11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget
branch
2 times, most recently
from
b763688
to
06c6eb5
Compare
maartenbreddels
force-pushed
the
11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget
branch
from
06c6eb5
to
484b166
Compare
Do not include a div in between temporarily. Since the widget view is created before we try to render the the upyter-widget-mount-point we do not need to get it asynchrounously via promises.
maartenbreddels
force-pushed
the
11-22-refactor_directly_render_vue_tree_if_root_view_is_a_ipyvue_widget
branch
from
484b166
to
7b07de4
Compare
iisakkirotko
force-pushed
the
master
branch
2 times, most recently
from
c2951b9
to
8816e36
Compare
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
240a079
to
b098da1
Compare
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
86646f5
to
df2fd66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include a div in between temporarily. Since the widget view
is created before we try to render the the upyter-widget-mount-point
we do not need to get it asynchrounously via promises.