xfd: New feature: Notify redirect target of RfD discussion #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amorymeltzer
force-pushed
the
xfd-notifyrelatedpage
branch
3 times, most recently
from
016ca57
to
d84fabb
Compare
Requested at WT:TW (https://en.wikipedia.org/w/index.php?oldid=885374731#Notifying_redirect_targets) Enabled by default and creates new preference, xfdWatchRelated, that works the same as xfdWatchUser
Amorymeltzer
force-pushed
the
xfd-notifyrelatedpage
branch
from
d84fabb
to
a5ae221
Compare
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Feb 21, 2020
1. Since wikimedia-gadgets#741 (specifically, 3e21765), RfD was using a returned `curtimestamp` to generate the log page. That query was only being done if the page wasn't a soft redirect, however, leading to NaN/undefined issues. Closes wikimedia-gadgets#861 by falling back to the previous client clock method. 2. wikimedia-gadgets#527 (44c0e42) added the ability to notify a redirect's target, but returns an error if the title is invalid, such as with soft redirects via {{wi}}. This now skips the notification in such cases.
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Aug 14, 2020
Quite a lineage here! When first added in wikimedia-gadgets#527 (a5ae221), that left a `mw.Title` object being passed to `targetNotification`, rather than the string that `Morebits.wiki.page` expects. This appears not to have actually been problem, however, until the ability to avoid following cross-namespace redirects was added in wikimedia-gadgets#915 (9544560). This meant that the `mw.Title` object was being passed into `new mw.Title`, which would quietly complain. It turns out that bug was epistatic to another misnaming from the addition of `getInputData` in wikimedia-gadgets#908 (df2aa16): a single `params.usertalk` remained, when the other had all been converted to `params.notifycreator`.
wiki-ST47
pushed a commit
to wiki-ST47/twinkle
that referenced
this pull request
Sep 2, 2020
1. Since wikimedia-gadgets#741 (specifically, 3e21765), RfD was using a returned `curtimestamp` to generate the log page. That query was only being done if the page wasn't a soft redirect, however, leading to NaN/undefined issues. Closes wikimedia-gadgets#861 by falling back to the previous client clock method. 2. wikimedia-gadgets#527 (44c0e42) added the ability to notify a redirect's target, but returns an error if the title is invalid, such as with soft redirects via {{wi}}. This now skips the notification in such cases.
wiki-ST47
pushed a commit
to wiki-ST47/twinkle
that referenced
this pull request
Sep 2, 2020
Quite a lineage here! When first added in wikimedia-gadgets#527 (a5ae221), that left a `mw.Title` object being passed to `targetNotification`, rather than the string that `Morebits.wiki.page` expects. This appears not to have actually been problem, however, until the ability to avoid following cross-namespace redirects was added in wikimedia-gadgets#915 (9544560). This meant that the `mw.Title` object was being passed into `new mw.Title`, which would quietly complain. It turns out that bug was epistatic to another misnaming from the addition of `getInputData` in wikimedia-gadgets#908 (df2aa16): a single `params.usertalk` remained, when the other had all been converted to `params.notifycreator`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested at WT:TW
Enabled by default and creates new preference, xfdWatchRelated, that works the same as xfdWatchUser