morebits: swallow fake triage success #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the page is in the queue but is already triaged, there'll be a false success. Real pain, this action is, increasinly seemingly like the more involved wikimedia-gadgets#930 would be cleaner.
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Oct 11, 2020
…s in queue Original structure from wikimedia-gadgets#930, where we can properly asses and handle cases, rather than just swallowing all errors and avoiding stuff like wikimedia-gadgets#1093/wikimedia-gadgets#1145 and wikimedia-gadgets#1150. Restore AfD's `triage` to where it (sensibly) was before wikimedia-gadgets#1093.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the page is in the queue but is already triaged, there'll be a false success.
Real pain, this action is, increasinly seemingly like the more involved #930 would be cleaner.