xfd: Fix AfD bug attempting to triage wrong page #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since wikimedia-gadgets#1093 (7a450cb), in an attempt to avoid pointless errors leading to *actual* errors, I moved the `pageobj.triage()` call to after the `Twinkle.xfd.currentRationale = null` limits such errors. This, however, meant that since then, AfD nominations were always trying to triage the *nomination* page, not the *nominated* page. This fixes that, although like wikimedia-gadgets#1093, in a somewhat kludgy way; anywhere else and we risk the page nomination resolving first (wikimedia-gadgets#1036). Increasingly thinking the original version of wikimedia-gadgets#930 would be the cleaner way to handle this.
|
Pushing now |
Amorymeltzer
added a commit
to Amorymeltzer/twinkle
that referenced
this pull request
Oct 11, 2020
…s in queue Original structure from wikimedia-gadgets#930, where we can properly asses and handle cases, rather than just swallowing all errors and avoiding stuff like wikimedia-gadgets#1093/wikimedia-gadgets#1145 and wikimedia-gadgets#1150. Restore AfD's `triage` to where it (sensibly) was before wikimedia-gadgets#1093.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1093 (7a450cb), in an attempt to avoid pointless errors leading to actual errors, I moved the
pageobj.triage()call to after theTwinkle.xfd.currentRationale = nulllimits such errors. This, however, meant that since then, AfD nominations were always trying to triage the nomination page, not the nominated page. This fixes that, although like #1093, in a somewhat kludgy way; anywhere else and we risk the page nomination resolving first (#1036). Increasingly thinking the original version of #930 would be the cleaner way to handle this.