Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morebits: Do triage properly, with extra query to determine if page is in queue #1152

Merged

Conversation

Amorymeltzer
Copy link
Collaborator

Original structure from #930, where we can properly asses and handle cases, rather than just swallowing all errors and avoiding stuff like #1093/#1145 and #1150. Restore AfD's triage to where it (sensibly) was before #1093.


Per the previously convo with @siddharthvp, not sure if this is better than the current system, but figured I'd put it up for consideration. It's an extra query if the page can be triaged, but otherwise avoids running into any errors.

…s in queue

Original structure from wikimedia-gadgets#930, where we can properly asses and handle cases, rather than just swallowing all errors and avoiding stuff like wikimedia-gadgets#1093/wikimedia-gadgets#1145 and wikimedia-gadgets#1150.  Restore AfD's `triage` to where it (sensibly) was before wikimedia-gadgets#1093.
@Amorymeltzer Amorymeltzer added the Module: morebits The morebits.js library label Oct 11, 2020
@siddharthvp
Copy link
Member

The real issue here appears to be: Morebits.status.onError(Twinkle.xfd.printRationale); -- rationale is printed along with Your deletion rationale is provided below, which you can copy and paste into a new XFD dialog if you wish to try again if any API request fails, which is ridiculous. It only needs to be shown if the API request that creates (or appends to) the discussion page fails, or if any API call leading up to that call fails.

@siddharthvp
Copy link
Member

I guess this is reasonable enough to merge for now, but I'll note that issues like would most likely get resolved the "proper" way when I rewrite XFD as part of i18n/l10n work. We won't need an extra query at that time.

@Amorymeltzer Amorymeltzer added this to the November 2020 update milestone Oct 18, 2020
@Amorymeltzer Amorymeltzer merged commit 658394d into wikimedia-gadgets:master Nov 10, 2020
@Amorymeltzer Amorymeltzer deleted the morebits-fulltriage branch November 10, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: morebits The morebits.js library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants