Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfd: Fix two bugs when RfDing soft redirects #862

Merged
merged 1 commit into from
Feb 21, 2020
Merged

xfd: Fix two bugs when RfDing soft redirects #862

merged 1 commit into from
Feb 21, 2020

Commits on Feb 21, 2020

  1. xfd: Fix two bugs when RfDing soft redirects 

    1. Since wikimedia-gadgets#741 (specifically, 3e21765), RfD was using a returned `curtimestamp` to generate the log page.  That query was only being done if the page wasn't a soft redirect, however, leading to NaN/undefined issues.  Closes wikimedia-gadgets#861 by falling back to the previous client clock method.
2. wikimedia-gadgets#527 (44c0e42) added the ability to notify a redirect's target, but returns an error if the title is invalid, such as with soft redirects via {{wi}}.  This now skips the notification in such cases.
    @Amorymeltzer
    Amorymeltzer committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    24be0f5 View commit details
    Browse the repository at this point in the history